Add ability to set read_buffer_size for websockets #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
snapview/tungstenite-rs#468 changed the read buffer from 64KB to 128KB. It also added a method
read_buffer_sizeso the read buffer size can be set. Currently there is no way to my knowledge so that Axum users can change the read buffer size.After upgrading to axum 0.8 I noticed increased memory usage for my Websocket server and I assume the high read buffer is contributing to this. Since my websocket only receives small messages I would like to set it to something smaller than 128KB.
Solution
Added
WebsocketUpgrade::read_buffer_sizeso that the read buffer size can be set.