Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method_not_allowed_fallback to router #2903

Merged
merged 24 commits into from
Oct 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
73ddf83
add method_not_allowed_fallback to router
Lachstec Sep 8, 2024
833daf8
add documentation for method fallback
Lachstec Sep 8, 2024
0617c75
add docs attribute to method fallback
Lachstec Sep 8, 2024
53d75a4
add method_not_allowed_fallback to router
Lachstec Sep 8, 2024
8f97008
add documentation for method fallback
Lachstec Sep 8, 2024
3aedc9a
add docs attribute to method fallback
Lachstec Sep 8, 2024
ce7a42f
Merge branch 'feat/method_fallback' of github.com:Lachstec/axum into …
Lachstec Sep 27, 2024
ff942bc
add no_run to docs for method_not_allowed_fallback
Lachstec Sep 27, 2024
61237da
add option to set fallback if no custom one exists
Lachstec Sep 29, 2024
19b13bb
change method_not_allowed_fallback to use default_fallback
Lachstec Sep 29, 2024
d59d203
switch conditions in match on default fallback
Lachstec Sep 29, 2024
4645f66
test that method_not_allowed_fallback respects previously set fallback
Lachstec Sep 29, 2024
7d2be52
cargo fmt
Lachstec Sep 29, 2024
10c16df
remove typo from docs
Lachstec Sep 29, 2024
bcb2579
remove unnecessary mut
Lachstec Sep 29, 2024
6cd8386
add test for method not allowed fallback with state
Lachstec Sep 29, 2024
6a0d9a2
add another test for method_not_allowed_fallback
Lachstec Oct 11, 2024
546458e
Merge branch 'main' into feat/method_fallback
Lachstec Oct 11, 2024
61f3460
use tap_inner macro and fix tests
Lachstec Oct 11, 2024
a6882c6
Adjust grammar and formatting
Lachstec Oct 12, 2024
da082a5
Better explain how method_not_allowed_fallback works
Lachstec Oct 12, 2024
5c384df
improve grammar and wording
Lachstec Oct 12, 2024
733f0aa
change handle_405 to default_fallback
Lachstec Oct 12, 2024
190a84a
Update axum/src/docs/routing/method_not_allowed_fallback.md
jplatte Oct 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add no_run to docs for method_not_allowed_fallback
Lachstec committed Sep 27, 2024
commit ff942bc28f1ed8f0d64f5717ec123b2bddca0246
4 changes: 2 additions & 2 deletions axum/src/docs/routing/method_not_allowed_fallback.md
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ Add a fallback [`Handler`] for the case where a route exists, but the method of
Sets the Fallback on the underlying [`MethodRouter`] to be called when it
matches no method.

```rust
```rust,no_run
use axum::{response::IntoResponse, routing::get, Router};

async fn hello_world() -> impl IntoResponse {
@@ -35,4 +35,4 @@ The Fallback only applies if there is a MethodRouter registered for the given Ro
but the method used in the Request is not specified. In the example, a GET on
Lachstec marked this conversation as resolved.
Show resolved Hide resolved
`http://localhost:3000` causes the `hello_world` handler to react, while issueing a
POST triggers `handle_405`. Calling an entirely different route, like `http://localhost:3000/hello`
jplatte marked this conversation as resolved.
Show resolved Hide resolved
causes `handle_405` to run.
causes `handle_405` to run.
Lachstec marked this conversation as resolved.
Show resolved Hide resolved