Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix safari e2e test #9757

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

fix(core): fix safari e2e test #9757

wants to merge 1 commit into from

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jan 17, 2025

No description provided.

@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Jan 17, 2025
Copy link
Member Author

EYHN commented Jan 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 53.31%. Comparing base (9f3b39f) to head (a9a7d9d).

Files with missing lines Patch % Lines
...fra/src/sync/indexer/impl/indexeddb/data-struct.ts 50.00% 5 Missing and 1 partial ⚠️
.../src/sync/indexer/impl/indexeddb/inverted-index.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9757      +/-   ##
==========================================
+ Coverage   49.24%   53.31%   +4.06%     
==========================================
  Files        1938     2190     +252     
  Lines       92298    98573    +6275     
  Branches    15585    16700    +1115     
==========================================
+ Hits        45455    52554    +7099     
+ Misses      44910    44614     -296     
+ Partials     1933     1405     -528     
Flag Coverage Δ
server-test 78.52% <ø> (ø)
unittest 32.09% <56.25%> (+2.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/fix/safari-e2e branch from 6cb780f to 5e4e280 Compare January 17, 2025 08:27
@EYHN EYHN force-pushed the eyhn/fix/safari-e2e branch from 5e4e280 to a9a7d9d Compare January 17, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant