stm32f4xx: usart disable #4306
Merged
stm32f4xx: usart disable #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an usart disable API, to help reduce power consumption
lschuermann
reviewed
Jan 13, 2025
chips/stm32f4xx/src/usart.rs
Outdated
Comment on lines
567
to
569
| pub fn disable(&self) { | ||
| self.registers.cr1.modify(CR1::UE::CLEAR); | ||
| } |
There was a problem hiding this comment.
Should this guard against the case where UART is disabled when an operation is still in progress?
There was a problem hiding this comment.
Thanks for the feedback! I added a check for ongoing transfers.
lschuermann
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request addes an usart disable API, to help reduce power consumption
Testing Strategy
This pull request was tested by disabling the usart and entering sleep mode, on a nucleo_f429zi board.
Documentation Updated
Formatting
make prepush.