doc: trd104: fix pointer->parameter #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrvanwhy
previously approved these changes
Jan 8, 2025
lschuermann
previously approved these changes
Jan 8, 2025
Huh, let's see whether re-opening fixes this LiteX test fluke. |
|
@bradjc Can you bump the draft version of this? |
I believe that referring to the "appdata" in subscribe as an "application data pointer" is unintentional, and that it should be "application data parameter" to match the earlier description. I believe this stems from userspace largely using that parameter to store a pointer, but we don't require that (and can't enforce it). This clarifies the document.
ppannuto
force-pushed
the
trd104-parameter-reword
branch
from
6b0fdad to
a31b20b
Compare
ppannuto
approved these changes
Jan 15, 2025
|
@lschuermann looks like something weird with litex still? |
Ever since I switched it to use the MLFQ scheduler it's been failing pretty non-deterministically. This is definitely something we should investigate, I think chances are that it's actually something related to MLFQ. |
|
Should we mark litex as a non-required status check until the MLFQ issue is resolved? |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
I believe that referring to the "appdata" in subscribe as an "application data pointer" in TRD104 is unintentional, and that it should be "application data parameter" to match the earlier description. I believe this stems from userspace largely using that parameter to store a pointer, but we don't require that (and can't enforce it). This clarifies the document.
Testing Strategy
docs
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.