Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-2608: Add an RSS feed for the TinyMCE Changelog #3566

Draft
wants to merge 12 commits into
base: tinymce/7
Choose a base branch
from
Draft

DOC-2608: Add an RSS feed for the TinyMCE Changelog #3566

wants to merge 12 commits into from
+292 −0

Conversation

FarzadHayat
Copy link
Contributor

@FarzadHayat FarzadHayat commented Dec 23, 2024 •
edited
Loading

Ticket: DOC-2608

Site: RSS URL
RSS Validator: https://validator.w3.org/feed/
RSS Viewer: https://rssviewer.app/
RSS Spec: https://www.rssboard.org/rss-specification

Changes:

  • Worked on this in my own time. Thought it would be a cool feature to have.
  • Add Antora extension to tinymce/7 to generate rss.xml during build process
  • Automatically updates when changelog.adoc is modified
  • Error handling mechanism to ensure build process continues if the extension fails for any reason
  • Test it out by installing an RSS Reader on your smart phone and entering the RSS URL

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.
  • [-] modules/ROOT/nav.adoc has been updated (if applicable).
  • [-] Included a release note entry for any New product features.
  • [-] If this is a minor release, updated productminorversion in antora.yml and added new supported versions entry in modules/ROOT/partials/misc/supported-versions.adoc.

Review:

  • Documentation Team Lead has reviewed

@FarzadHayat FarzadHayat self-assigned this Dec 23, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 23, 2024
View reviewed changes
lib/rssfeed.cjs Fixed Show fixed Hide fixed
@FarzadHayat @github-advanced-security
Fix code scanning alert no. 35: Incomplete string escaping or encoding
9c88453 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 23, 2024
View reviewed changes
lib/rssfeed.cjs Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavgandham abhinavgandham Awaiting requested review from abhinavgandham abhinavgandham will be requested when the pull request is marked ready for review abhinavgandham is a code owner

@soritaheng soritaheng Awaiting requested review from soritaheng soritaheng will be requested when the pull request is marked ready for review soritaheng is a code owner

@LewisAtTiny LewisAtTiny Awaiting requested review from LewisAtTiny LewisAtTiny will be requested when the pull request is marked ready for review LewisAtTiny is a code owner

@kemister85 kemister85 Awaiting requested review from kemister85 kemister85 will be requested when the pull request is marked ready for review kemister85 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@FarzadHayat FarzadHayat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FarzadHayat