Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: delete the extra cast in cstyle load [run_process_replay] [no_assert] #5310

Merged
merged 4 commits into from
Jul 7, 2024
Merged

test: delete the extra cast in cstyle load [run_process_replay] [no_assert] #5310

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56ff06c
test: delete the extra cast in cstyle load [run_process_replay] [no_a…
Qazalin Jul 6, 2024
4e1f8b5
assert buf_uop
Qazalin Jul 6, 2024
6976e5e
ImageDType
Qazalin Jul 6, 2024
5839910
ptx is actually a 64bit address
Qazalin Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ptx is actually a 64bit address
  • Loading branch information
@Qazalin
Qazalin committed Jul 6, 2024
commit 583991049a4d82122b18adfa2a3e699941d1a05b
6 changes: 2 additions & 4 deletions tinygrad/codegen/uops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from collections import defaultdict
from enum import Enum, auto
from dataclasses import dataclass, field
from tinygrad.dtype import ConstType, ImageDType, dtypes, DType
from tinygrad.dtype import ConstType, dtypes, DType
from tinygrad.shape.symbolic import sint, Variable
from tinygrad.ops import UnaryOps, BinaryOps, TernaryOps, exec_alu
from tinygrad.helpers import prod, DEBUG, getenv
Expand Down Expand Up @@ -98,9 +98,7 @@ def type_verify(uops):
assert dtype is not None and type(arg) is type(dtypes.as_const(arg, dtype)), f"type of {arg=} does not match {dtype}"
if uop in {UOps.CAST, UOps.BITCAST}: assert arg is None # type is the output type, not an arg
if uop is UOps.CAST and dtype is not None and dtype.count > 1: assert len(src) == dtype.count
if uop is UOps.LOAD and len(src) > 3 and src[2].op is UOps.ALU:
assert (dtypes.float if isinstance(buf_dtype:=src[0].dtype, ImageDType) else buf_dtype) == dtype.scalar()
assert src[2].dtype == dtypes.bool and src[3].dtype == dtype
if uop is UOps.LOAD and len(src) > 3 and src[2].op is UOps.ALU: assert src[2].dtype == dtypes.bool and src[3].dtype == dtype
if uop is UOps.STORE:
assert dtype is None, f"{uop} dtype must be None, got {dtype}"
if len(src) == 4: assert src[3].dtype == dtypes.bool, f"gate dtype mismatch {src[3].dtype} != {dtypes.bool}"
Expand Down