Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate file have trailing dot of theme file doesn't have a file extension #88

Merged
merged 2 commits into from
Dec 29, 2024
Merged

fix: generate file have trailing dot of theme file doesn't have a file extension #88

merged 2 commits into from
Dec 29, 2024

Conversation

bezhermoso
Copy link
Member

☝️ As the title says, if the theme file doesn't have a file extension, the generated file will have a trailing dot e.g.:

~/.local/share/tinted-theming/tinty/repos/tinted-terminal/themes/ghostty/base16-3024

# ... produces:

~/.local/share/tinted-theming/tinty/tinted-terminal-themes-ghostty-file.

This is probably not a common case, but Ghostty uses the theme filename as the theme name itself. This patch makes it so that these kinds of files are copied over without an extension.

(I'm new to Rust 🙃 so apologies in advance!)

@bezhermoso bezhermoso requested a review from a team as a code owner December 27, 2024 18:51
@bezhermoso bezhermoso requested review from JamyGolden and removed request for a team December 27, 2024 18:51
JamyGolden
JamyGolden reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The rust code looks good 😄 Can you add the following to the top of the changelog file:

# Changelog

## Unreleased

### Fixed

- Fix bug where period preceeding extension is still added to generated files even when an extension doesn't exist

@JamyGolden JamyGolden merged commit 0b87d1b into tinted-theming:main Dec 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamyGolden JamyGolden Awaiting requested review from JamyGolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bezhermoso @JamyGolden