Skip to content

[Bug report] The scope of "BASE16_SHELL_THEME_NAME_PATH" and "BASE16_SHELL_COLORSCHEME_PATH" in profile_helper.fish is needed to be global #59

Closed
@mikelue

Description

@mikelue

Describe the bug

While using profile_helper.fish, there would be an error:

ln: failed to create symbolic link '': No such file or directory
Attempted symbolic link failed. Ensure $BASE16_SHELL_PATH     and $BASE16_SHELL_COLORSCHEME_PATH are valid paths.

Expected behavior

No error output

Screenshots

System

Operating system: Linux 5.15.167.4-microsoft-standard-WSL2 #1 SMP Tue Nov 5 00:21:55 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Terminal: Windows Terminal

Minimal configuration file

Additional context

I guess that the adding of -g would make BASE16_SHELL_THEME_NAME_PATH and $BASE16_SHELL_COLORSCHEME_PATH visible in set_theme function

set -g BASE16_SHELL_COLORSCHEME_PATH \
  "$BASE16_CONFIG_PATH/base16_shell_theme"

set -g BASE16_SHELL_THEME_NAME_PATH "$BASE16_CONFIG_PATH/theme_name"

Activity

changed the title [Bug report] The scope of "BASE16_SHELL_COLORSCHEME_PATH" in profile_helper.fish is needed to be global [Bug report] The scope of "BASE16_SHELL_THEME_NAME_PATH" and "BASE16_SHELL_COLORSCHEME_PATH" in profile_helper.fish is needed to be global on Jan 15, 2025
JamyGolden

JamyGolden commented on Jan 15, 2025

@JamyGolden
Member

Thanks for reporting. BASE16_SHELL_THEME_NAME_PATH is used by some hooks so that would create an error. I've just merged the changes in, can you test to see if this fixes the problem? #60

Out of interest, have you had a look at Tinty and decided to continue using the profile helper anyway?

mikelue

mikelue commented on Jan 15, 2025

@mikelue
Author

Thanks for reporting. BASE16_SHELL_THEME_NAME_PATH is used by some hooks so that would create an error. I've just merged the changes in, can you test to see if this fixes the problem? #60

Out of interest, have you had a look at Tinty and decided to continue using the profile helper anyway?

Everything is fixed. Thanks a lot.
I will go for Tinty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    [Bug report] The scope of "BASE16_SHELL_THEME_NAME_PATH" and "BASE16_SHELL_COLORSCHEME_PATH" in profile_helper.fish is needed to be global · Issue #59 · tinted-theming/tinted-shell