Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Ansi16 style - All 16 ANSI colors #53

Open
joshgoebel opened this issue Jul 7, 2022 · 4 comments
Open

Proposal: Ansi16 style - All 16 ANSI colors #53

joshgoebel opened this issue Jul 7, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request proposal An idea which may or may not be acted on
Milestone

Comments

@joshgoebel
Copy link
Contributor

joshgoebel commented Jul 7, 2022

Feel free to take this issue and make it your own.

@joshgoebel joshgoebel added the enhancement New feature or request label Jul 7, 2022
@joshgoebel
Copy link
Contributor Author

joshgoebel commented Jul 7, 2022

@belak Were you imagining that any existing ANSI schemes can work, or that only hand-crafted schemes that very carefully tweaked their colors just right for UI could work? I was imagining just "normal" ANSI and that apps would have to work within that constraint (if they are truly 16 color only)

I was just wondering if we could bootstrap Ansi16 with a whole library of existing 16 color terminal themes like: https://github.com/mbadolato/iTerm2-Color-Schemes

IE:

  • write the Ansi16 style spec
  • bootstrap the library of schemes
  • write a template or two
  • write the interop (with other style specs)

@belak
Copy link
Member

belak commented Jul 7, 2022

My original plan for the library of schemes was to do it slowly - start with something like xterm and terminal-app (The wikipedia page for ANSI escape codes has a number of them right there).

The only other one I've used regularly is Hybrid which uses the tomorrow-night palate (with some tweaks), but works better in a terminal.

@joshgoebel
Copy link
Contributor Author

Hmmmm, if the themes are high quality isn't more better than 2 or 3? I was more asking if there is anything particular about your style guide/design that would prevent normal ANSI themes from being workable...

@belak
Copy link
Member

belak commented Jul 7, 2022

I'd prefer to start with just a few, and add more once we prove it works well - it's way easier to build a theme when you're focusing on one or two color schemes (usually a light and dark) rather than on 50.

@belak belak added proposal An idea which may or may not be acted on and removed discussion labels Jul 8, 2022
@belak belak changed the title Ansi16 style - All 16 ANSI colors Proposal: Ansi16 style - All 16 ANSI colors Jul 8, 2022
@joshgoebel joshgoebel added this to the Ansi16 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal An idea which may or may not be acted on
Projects
None yet
Development

No branches or pull requests

2 participants