New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(min_k8s_version): Remove --short flag for kubectl version #520

Closed

hiohiohio wants to merge 1 commit into tilt-dev:master from hiohiohio:fix-min-k8s-version-kubectl-version-short

hiohiohio commented Aug 18, 2023 •

edited

Loading

Context:

kubectl deprecated --short flag for kubectl version at v1.24 Start deprecating long/golang version information kubernetes/kubernetes#108987
kubectl removed --short flag for kubectl version at v1.28 Remove long/golang version information making short the default kubernetes/kubernetes#116720
currently we have an error in the below with kubectl v1.28
default output is changed as same as --short flag

Error in local: command "kubectl version --short" failed.
error: exit status 1
stdout: ""
stderr: "error: unknown flag: --short\nSee 'kubectl version --help' for usage.\n"

Changes:

removed --short flag for kubectl version in min_k8s_version
min_k8s_version requires kubectl v1.28+


          fix(min_k8s_version): remove --short flag for kubectl version

dfda168

Signed-off-by: Chihiro Hio <chihiro.hio@gmail.com>

turip mentioned this pull request

Fix min version issue with k8s client #521

Merged

Member

nicks commented Aug 23, 2023

Thanks! I'm going to close this as duplicating #521, which handles backwards compatibility a little better

nicks closed this

nicks added the duplicate label

hiohiohio deleted the fix-min-k8s-version-kubectl-version-short branch

August 24, 2023 03:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels