Merge pull request #116 from tidy-finance/115-download_datafactors_q5…

…_annual-does-not-work Fix bug with `download_data("factors q5 annual")`
tidy-finance · Nov 18, 2024 · 495d542 · 495d542
2 parents e0e2e4c + aaa8508
commit 495d542
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: tidyfinance
 Title: Tidy Finance Helper Functions
-Version: 0.4.1.9002
+Version: 0.4.1.9003
 Authors@R: c(
     person("Christoph", "Scheuch", , "christoph.scheuch@gmail.com", role = c("aut", "cre", "cph"),
            comment = c(ORCID = "0009-0004-0423-6819")),

diff --git a/NEWS.md b/NEWS.md
@@ -3,6 +3,7 @@
 ## Improvements
 
 * Updated `ccmxpf_linktable` to the new WRDS default `ccmxpf_lnkhist`.
+* Added support for "factors_q5_annual" in `download_factors_q()`
 
 # tidyfinance 0.4.1
 

diff --git a/R/download_data_factors.R b/R/download_data_factors.R
@@ -154,6 +154,7 @@ download_data_factors_ff <- function(
 #' @examples
 #' \donttest{
 #'   download_data_factors_q("factors_q5_daily", "2020-01-01", "2020-12-31")
+#'   download_data_factors_q("factors_q5_annual")
 #' }
 download_data_factors_q <- function(
     type, start_date = NULL, end_date = NULL, url = "https://global-q.org/uploads/1/2/2/6/122679606/"
@@ -181,6 +182,9 @@ download_data_factors_q <- function(
   } else if (grepl("daily", type, fixed = TRUE)) {
     processed_data <- raw_data |>
       mutate(DATE = ymd(DATE))
+  } else if (grepl("annual", type, fixed = TRUE)) {
+    processed_data <- raw_data |>
+      mutate(date = year)
   }
 
   processed_data <- processed_data |>

diff --git a/man/download_data_factors_q.Rd b/man/download_data_factors_q.Rd