Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-171: Add PlayLog test 4 #50

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

stoyicker
Copy link
Contributor

No description provided.

These tests are no longer flaky when it comes to asserting before reporting has
finished, so the repeat mechanism is no longer required in that sense.

If the timeout for playback proves to be a problem, then that should be bumped
instead, as it is virtually higher for other tests (they use the same timeout
for playback completion, even though said playback is not full).
@stoyicker stoyicker requested a review from a team as a code owner June 27, 2024 14:47
This also allows reusing the dispatcher configuration which all tests using a
single MediaProduct need.
@stoyicker stoyicker force-pushed the jantonio/delete_multiplexing branch from faa773e to b993d58 Compare June 27, 2024 17:23
@stoyicker stoyicker force-pushed the jantonio/playlog_test_4 branch from e40f185 to f98de5e Compare June 27, 2024 17:24
ziad-halabi9
ziad-halabi9 previously approved these changes Jun 28, 2024
@stoyicker stoyicker force-pushed the jantonio/delete_multiplexing branch from b993d58 to e52c576 Compare August 5, 2024 08:07
@stoyicker stoyicker force-pushed the jantonio/playlog_test_4 branch from f98de5e to ac676b6 Compare August 30, 2024 11:34
@stoyicker stoyicker changed the title Add PlayLog test 4 MF-171: Add PlayLog test 4 Aug 30, 2024
@stoyicker stoyicker force-pushed the jantonio/delete_multiplexing branch from e52c576 to 05ab310 Compare August 30, 2024 11:40
@stoyicker stoyicker requested a review from a team September 4, 2024 11:05
Base automatically changed from jantonio/delete_multiplexing to main October 1, 2024 05:20
@stoyicker stoyicker dismissed ziad-halabi9’s stale review October 1, 2024 05:20

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants