Update linting rules, ignore some warnings for now

ti-broish · Jan 31, 2023 · 60ffa3c · 60ffa3c
1 parent b14f611
commit 60ffa3c
Show file tree

Hide file tree

Showing 11 changed files with 54 additions and 22 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -3,10 +3,12 @@ module.exports = {
   parserOptions: {
     project: 'tsconfig.json',
     sourceType: 'module',
+    extraFileExtensions: ['.json'],
   },
   plugins: ['@typescript-eslint/eslint-plugin'],
   extends: [
     'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/recommended-requiring-type-checking',
     'plugin:prettier/recommended',
   ],
   root: true,
@@ -15,6 +17,18 @@ module.exports = {
     jest: true,
   },
   rules: {
+    '@typescript-eslint/require-await': 'warn',
+    '@typescript-eslint/unbound-method': 'warn',
+    '@typescript-eslint/no-unsafe-assignment': 'warn',
+    '@typescript-eslint/no-unsafe-return': 'warn',
+    '@typescript-eslint/no-unsafe-argument': 'warn',
+    '@typescript-eslint/no-unsafe-member-access': 'warn',
+    '@typescript-eslint/no-unsafe-call': 'warn',
+    '@typescript-eslint/no-floating-promises': 'warn',
+    '@typescript-eslint/restrict-template-expressions': 'warn',
+    '@typescript-eslint/no-misused-promises': ['error', {
+      checksVoidReturn: false,
+    }],
     '@typescript-eslint/interface-name-prefix': 'off',
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/explicit-module-boundary-types': 'off',

diff --git a/package.json b/package.json
@@ -19,8 +19,8 @@
     "start:debug": "nest start --debug --watch",
     "start:prod": "node dist/main",
     "deploy:demo": "pm2 deploy demo-ecosystem.config.js production update",
-    "lint": "eslint \"{src,scripts,test,@types}/**/*.ts\" --fix",
-    "lint:ci": "eslint \"{src,scripts,test,@types}/**/*.ts\"",
+    "lint": "eslint \"{src,scripts,test,@types}/**/*.ts\" --fix --quiet",
+    "lint:ci": "eslint \"{src,scripts,test,@types}/**/*.ts\" --fix-dry-run --quiet",
     "test": "jest --passWithNoTests",
     "test:watch": "jest --watch",
     "test:cov": "jest --coverage",
@@ -138,8 +138,8 @@
     "testEnvironment": "node"
   },
   "lint-staged": {
-    "*": [
-      "prettier --write --ignore-unknown"
+    "(src|scripts|test|@types)/**/*.(ts|js)": [
+      "eslint --fix --quiet"
     ]
   },
   "main": "dist/main.js",

diff --git a/scripts/import-results.ts b/scripts/import-results.ts
@@ -14,7 +14,13 @@ const escValue = (value: string | number): string => {
     return value;
   }
 
-  return "'" + ('' + value).replace(/'/g, "''") + "'";
+  if (typeof value === 'number') {
+    value = value.toString();
+  }
+
+  value = value.replace(/'/g, "''");
+
+  return `'${value}'`;
 };
 
 const insertTemplate = `INSERT INTO :table (:columns) values (:values);`;

diff --git a/src/app.module.ts b/src/app.module.ts
@@ -33,7 +33,7 @@ import { CommandModule } from 'nestjs-command';
     ConfigModule.forRoot({ validationSchema: configSchema }),
     I18nModule.forRootAsync({
       imports: [ConfigModule],
-      useFactory: async (configService: ConfigService) => ({
+      useFactory: (configService: ConfigService) => ({
         fallbackLanguage: configService.get('NEST_LANG', 'bg'),
         loaderOptions: {
           path: path.join(__dirname, '/i18n/'),

diff --git a/src/auth/auth-basic.strategy.ts b/src/auth/auth-basic.strategy.ts
@@ -11,7 +11,11 @@ export class BasicStrategy extends PassportStrategy(Strategy) {
     });
   }
 
-  public validate = async (req, username, password): Promise<boolean> => {
+  public validate = async (
+    _: any,
+    username: string,
+    password: string,
+  ): Promise<boolean> => {
     if (
       this.configService.get<string>('STREAMS_WEBHOOK_USERNAME') === username &&
       this.configService.get<string>('STREAMS_WEBHOOK_PASSWORD') === password

diff --git a/src/i18n/translate-status.interceptor.ts b/src/i18n/translate-status.interceptor.ts
@@ -56,7 +56,7 @@ export class TranslateStatusInterceptor implements NestInterceptor {
         .replace('Dto', '')
         .toUpperCase();
       try {
-        object.statusLocalized = await this.i18n.translate(
+        object.statusLocalized = this.i18n.translate(
           `status.${objectType}_${object.status.toUpperCase()}`,
           { lang },
         );

diff --git a/src/protocols/entities/work-items.repository.ts b/src/protocols/entities/work-items.repository.ts
@@ -98,7 +98,7 @@ export class WorkItemsRepository {
       .limit(200)
       .orderBy('workItem.id', 'ASC');
 
-    return (await qb.getOneOrFail()) as WorkItem;
+    return await qb.getOneOrFail();
   }
 
   async findCompletedItems(): Promise<WorkItem[]> {

diff --git a/src/results/api/results.controller.ts b/src/results/api/results.controller.ts
@@ -571,9 +571,7 @@ export class ResultsController {
     section.results = (await this.sectionsRepo.getResultsFor(
       section.id,
     )) as number[];
-    section.protocols = (await this.protocolsRepo.findBySection(
-      section.id,
-    )) as Protocol[];
+    section.protocols = await this.protocolsRepo.findBySection(section.id);
 
     return {
       ...sectionMapper(section),

diff --git a/src/sections/entities/sections.repository.ts b/src/sections/entities/sections.repository.ts
@@ -201,13 +201,13 @@ export class SectionsRepository {
     let violationsCountTown = 0;
     stats.forEach((x) =>
       Object.keys(x).includes('violationsCountTown')
-        ? (violationsCountTown = parseInt(x.violationsCountTown))
+        ? (violationsCountTown = parseInt(x.violationsCountTown, 10))
         : (violationsCountTown = 0),
     );
     stats.forEach((x) =>
       Object.keys(x).includes('violationsCount')
         ? (x.violationsCount =
-            parseInt(x.violationsCount) + violationsCountTown)
+            parseInt(x.violationsCount, 10) + violationsCountTown)
         : x.violatinsCount,
     );
 
@@ -227,9 +227,12 @@ export class SectionsRepository {
                 'violationsCountTown',
               )
                 ? (output[singleStat.segment].violationsCount =
-                    parseInt(output[singleStat.segment].violationsCount) +
-                    output[singleStat.segment].violationsCountTown)
-                : output[singleStat.segment].violationsCount;
+                    parseInt(output[singleStat.segment].violationsCount, 10) +
+                    parseInt(
+                      output[singleStat.segment].violationsCountTown,
+                      10,
+                    ))
+                : parseInt(output[singleStat.segment].violationsCount, 10);
             });
             delete singleStat.segment;
           });

diff --git a/src/users/api/user.dto.ts b/src/users/api/user.dto.ts
@@ -133,9 +133,13 @@ export class UserDto {
     groups: [UserDto.CREATE, UserDto.UPDATE],
     message: 'USER_EMAIL_LENGTH',
   })
-  @Transform(({ value: email }) => (email ? email.toLowerCase() : email), {
-    groups: [UserDto.CREATE, UserDto.UPDATE],
-  })
+  @Transform(
+    ({ value: email }: { value: string }) =>
+      email ? email.toLowerCase() : email,
+    {
+      groups: [UserDto.CREATE, UserDto.UPDATE],
+    },
+  )
   email: string;
 
   @ApiProperty({ required: true })

diff --git a/src/utils/csvToSql.ts b/src/utils/csvToSql.ts
@@ -39,8 +39,11 @@ const createRecordsToInsertsTransformer = (
         .replace(
           ':values',
           Object.entries(record)
-            .map(([key, value]) => {
-              const str = ('' + value).trim();
+            .map(([key, value]: [string, string | number]) => {
+              if (typeof value === 'number') {
+                value = value.toString();
+              }
+              const str = value.trim();
 
               return escValue(str.length > 0 ? str : emptyColumnCallback(key));
             })