Use jsx extension for react components

Lets keep defaults for for how esbuild and other build tools work with react. Its also less configuration we have to add.
thoughtbot · Dec 31, 2024 · ea2bedd · ea2bedd
1 parent ff3d20d
commit ea2bedd
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 6 deletions.
diff --git a/superglue_rails/lib/generators/superglue/install/install_generator.rb b/superglue_rails/lib/generators/superglue/install/install_generator.rb
@@ -72,7 +72,7 @@ def copy_ts_files
 
       def copy_js_files
         say "Copying application.js file to #{app_js_path}"
-        copy_file "#{__dir__}/templates/js/application.js", "#{app_js_path}/application.js"
+        copy_file "#{__dir__}/templates/js/application.jsx", "#{app_js_path}/application.jsx"
 
         say "Copying page_to_page_mapping.js file to #{app_js_path}"
         copy_file "#{__dir__}/templates/js/page_to_page_mapping.js", "#{app_js_path}/page_to_page_mapping.js"
@@ -87,8 +87,8 @@ def copy_js_files
         copy_file "#{__dir__}/templates/js/application_visit.js", "#{app_js_path}/application_visit.js"
 
         say "Copying components to #{app_js_path}"
-        copy_file "#{__dir__}/templates/js/inputs.js", "#{app_js_path}/components/Inputs.js"
-        copy_file "#{__dir__}/templates/js/layout.js", "#{app_js_path}/components/Layout.js"
+        copy_file "#{__dir__}/templates/js/inputs.jsx", "#{app_js_path}/components/Inputs.jsx"
+        copy_file "#{__dir__}/templates/js/layout.jsx", "#{app_js_path}/components/Layout.jsx"
         copy_file "#{__dir__}/templates/js/components.js", "#{app_js_path}/components/index.js"
 
         say "Copying jsconfig.json file to #{app_js_path}"

diff --git a/...rglue/install/templates/js/application.js → ...glue/install/templates/js/application.jsx b/...rglue/install/templates/js/application.js → ...glue/install/templates/js/application.jsx
diff --git a/.../superglue/install/templates/js/inputs.js → ...superglue/install/templates/js/inputs.jsx b/.../superglue/install/templates/js/inputs.js → ...superglue/install/templates/js/inputs.jsx
diff --git a/.../superglue/install/templates/js/layout.js → ...superglue/install/templates/js/layout.jsx b/.../superglue/install/templates/js/layout.js → ...superglue/install/templates/js/layout.jsx
diff --git a/...glue/view_collection/templates/js/edit.js → ...lue/view_collection/templates/js/edit.jsx b/...glue/view_collection/templates/js/edit.js → ...lue/view_collection/templates/js/edit.jsx
diff --git a/...lue/view_collection/templates/js/index.js → ...ue/view_collection/templates/js/index.jsx b/...lue/view_collection/templates/js/index.js → ...ue/view_collection/templates/js/index.jsx
diff --git a/...rglue/view_collection/templates/js/new.js → ...glue/view_collection/templates/js/new.jsx b/...rglue/view_collection/templates/js/new.js → ...glue/view_collection/templates/js/new.jsx
diff --git a/...glue/view_collection/templates/js/show.js → ...lue/view_collection/templates/js/show.jsx b/...glue/view_collection/templates/js/show.js → ...lue/view_collection/templates/js/show.jsx
diff --git a/superglue_rails/lib/generators/superglue/view_collection/view_collection_generator.rb b/superglue_rails/lib/generators/superglue/view_collection/view_collection_generator.rb
@@ -46,7 +46,7 @@ def copy_js_files
             filename = filename_with_tsx_extensions(view)
             template "ts/" + filename, File.join("app/views", controller_file_path, filename)
           else
-            filename = filename_with_js_extensions(view)
+            filename = filename_with_jsx_extensions(view)
             template "js/" + filename, File.join("app/views", controller_file_path, filename)
           end
         end
@@ -148,8 +148,8 @@ def filename_with_extensions(name)
         [name, :json, :props].join(".")
       end
 
-      def filename_with_js_extensions(name)
-        [name, :js].join(".")
+      def filename_with_jsx_extensions(name)
+        [name, :jsx].join(".")
       end
 
       def filename_with_tsx_extensions(name)