Remove extra pagekey assign

thoughtbot · Dec 12, 2024 · e63566a · e63566a
1 parent 66bb600
commit e63566a
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 13 deletions.
diff --git a/superglue/lib/reducers/index.ts b/superglue/lib/reducers/index.ts
@@ -55,7 +55,7 @@ function handleSaveResponse(
   state = { ...state }
 
   let nextPage: Page = {
-    pageKey,
+    // pageKey,
     ...page,
     savedAt: Date.now(),
   }

diff --git a/superglue/lib/types/index.ts b/superglue/lib/types/index.ts
@@ -166,7 +166,7 @@ export type VisitResponse<T = JSONMappable> = {
  */
 export type Page<T = JSONMappable> = VisitResponse<T> & {
   savedAt: number
-  pageKey: PageKey
+  // pageKey: PageKey
 }
 
 /**

diff --git a/superglue/spec/features/navigation.spec.jsx b/superglue/spec/features/navigation.spec.jsx
@@ -106,7 +106,6 @@ describe('start', () => {
       },
       pages: {
         '/home?some=123': {
-          pageKey: '/home?some=123',
           fragments: [],
           data: {
             heading: 'this is page 1',
@@ -173,7 +172,6 @@ describe('navigation', () => {
         csrfToken: 'token',
         assets: ['application-123.js', 'application-123.js'],
         componentIdentifier: 'about',
-        pageKey: '/about',
         fragments: [],
         savedAt: expect.any(Number),
       }
@@ -240,7 +238,6 @@ describe('navigation', () => {
         csrfToken: 'token',
         assets: ['application-123.js', 'application-123.js'],
         componentIdentifier: 'about',
-        pageKey: '/about',
         fragments: [],
         savedAt: expect.any(Number),
       }
@@ -574,7 +571,6 @@ describe('navigation', () => {
         csrfToken: 'token',
         assets: ['application-123.js', 'application-123.js'],
         componentIdentifier: 'about',
-        pageKey: '/about',
         fragments: [],
         savedAt: expect.any(Number),
       }

diff --git a/superglue/spec/lib/reducers.spec.js b/superglue/spec/lib/reducers.spec.js
@@ -388,7 +388,6 @@ describe('reducers', () => {
             data: {},
             csrfToken: 'token',
             assets: ['application-123.js'],
-            pageKey: '/foo',
             fragments: [],
             savedAt: expect.any(Number),
           })
@@ -436,7 +435,6 @@ describe('reducers', () => {
                 },
               },
             },
-            pageKey: '/foo',
             defers: [
               { url: '/foo?props_at=data.foo.bar', path: 'data.foo.bar' },
             ],
@@ -472,7 +470,6 @@ describe('reducers', () => {
               },
             },
           },
-          pageKey: '/foo',
           defers: [{ url: '/foo?props_at=data.foo.bar', path: 'data.foo.bar' }],
           fragments: [],
           savedAt: expect.any(Number),
@@ -489,7 +486,6 @@ describe('reducers', () => {
                 },
               },
             },
-            pageKey: '/bar',
             defers: [
               { url: '/bar?props_at=data.foo.bar', path: 'data.foo.bar' },
             ],
@@ -527,7 +523,6 @@ describe('reducers', () => {
             },
             baz: 'received',
           },
-          pageKey: '/bar',
           defers: [{ url: '/bar?props_at=data.foo.bar', path: 'data.foo.bar' }],
           fragments: [{ type: 'info', partial: 'info', path: 'data.foo.bar' }],
           savedAt: expect.any(Number),
@@ -544,7 +539,6 @@ describe('reducers', () => {
                 },
               },
             },
-            pageKey: '/bar',
             defers: [
               { url: '/bar?props_at=data.foo.bar', path: 'data.foo.bar' },
             ],
@@ -576,7 +570,6 @@ describe('reducers', () => {
               bar: {},
             },
           },
-          pageKey: '/foo',
           defers: [{ url: '/foo?props_at=data.foo.bar', path: 'data.foo.bar' }],
           fragments: [{ type: 'info', partial: 'info', path: 'data.foo.bar' }],
           savedAt: expect.any(Number),