feat: initialize typescript (#60)

* feat: initialize typescript * chore: keep babel * chore: remove sourcemaps, @types/url-parse
thoughtbot · Jun 11, 2024 · 3677d94 · 3677d94
1 parent aaba7da
commit 3677d94
Show file tree

Hide file tree

Showing 20 changed files with 68 additions and 26 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/superglue/.babelrc.js b/superglue/.babelrc.js
@@ -1,6 +1,6 @@
 module.exports = {
   plugins: [
-    ["transform-react-remove-prop-types", {removeImport: true}]
+    ["transform-react-remove-prop-types", { removeImport: true }]
   ],
   presets: [
     [
@@ -14,5 +14,8 @@ module.exports = {
     [
       "@babel/preset-react"
     ],
+    [
+      "@babel/preset-typescript"
+    ],
   ],
 };
diff --git a/superglue/lib/action_creators/index.js → superglue/lib/action_creators/index.ts b/superglue/lib/action_creators/index.js → superglue/lib/action_creators/index.ts
diff --git a/superglue/lib/action_creators/requests.js → superglue/lib/action_creators/requests.ts b/superglue/lib/action_creators/requests.js → superglue/lib/action_creators/requests.ts
diff --git a/superglue/lib/actions.js → superglue/lib/actions.ts b/superglue/lib/actions.js → superglue/lib/actions.ts
diff --git a/superglue/lib/components/Nav.js → superglue/lib/components/Nav.tsx b/superglue/lib/components/Nav.js → superglue/lib/components/Nav.tsx
@@ -1,9 +1,26 @@
 import React from 'react'
 import { urlToPageKey, pathWithoutBZParams } from '../utils'
 import { REMOVE_PAGE, HISTORY_CHANGE } from '../actions'
-import PropTypes from 'prop-types'
 
-class Nav extends React.Component {
+interface Props {
+  store: any
+  history: any
+  mapping: any
+  visit: any
+  remote: any
+  initialPageKey: any
+}
+
+interface State {
+  pageKey: any
+  ownProps: any
+}
+
+class Nav extends React.Component<Props, State> {
+  public history
+  public hasWindow
+  public unsubscribeHistory
+
   constructor(props) {
     super(props)
     const { history, initialPageKey } = this.props
@@ -211,13 +228,4 @@ class Nav extends React.Component {
   }
 }
 
-Nav.propTypes = {
-  store: PropTypes.object,
-  history: PropTypes.object,
-  mapping: PropTypes.object,
-  visit: PropTypes.func,
-  remote: PropTypes.func,
-  initialPageKey: PropTypes.string,
-}
-
 export default Nav
diff --git a/superglue/lib/config.js → superglue/lib/config.ts b/superglue/lib/config.js → superglue/lib/config.ts
diff --git a/superglue/lib/index.js → superglue/lib/index.tsx b/superglue/lib/index.js → superglue/lib/index.tsx
@@ -15,7 +15,6 @@ import thunk from 'redux-thunk'
 import { Provider, connect } from 'react-redux'
 import { createBrowserHistory, createMemoryHistory } from 'history'
 import Nav from './components/Nav'
-import PropTypes from 'prop-types'
 
 export {
   BEFORE_FETCH,
@@ -40,7 +39,6 @@ export {
   superglueReducer,
   pageReducer,
   rootReducer,
-  updateFragments,
 } from './reducers'
 export { fragmentMiddleware } from './middleware'
 export { getIn } from './utils/immutability'
@@ -94,7 +92,25 @@ class NotImplementedError extends Error {
   }
 }
 
-export class ApplicationBase extends React.Component {
+interface Props {
+  initialPage: any
+  baseUrl: any
+  path: any
+}
+
+interface Store {}
+
+export class ApplicationBase extends React.Component<Props, Store> {
+  public hasWindow: any
+  public navigatorRef: any
+  public initialPageKey: any
+  public store: any
+  public history: any
+  public connectedMapping: any
+  public ujsHandlers: any
+  public visit: any
+  public remote: any
+
   constructor(props) {
     super(props)
     this.hasWindow = typeof window !== 'undefined'
@@ -220,10 +236,3 @@ export class ApplicationBase extends React.Component {
     )
   }
 }
-
-ApplicationBase.propTypes = {
-  initialPage: PropTypes.object,
-  baseUrl: PropTypes.string,
-  path: PropTypes.string,
-  appEl: PropTypes.object,
-}
diff --git a/superglue/lib/middleware.js → superglue/lib/middleware.ts b/superglue/lib/middleware.js → superglue/lib/middleware.ts
diff --git a/superglue/lib/reducers/index.js → superglue/lib/reducers/index.ts b/superglue/lib/reducers/index.js → superglue/lib/reducers/index.ts
diff --git a/superglue/lib/utils/helpers.js → superglue/lib/utils/helpers.ts b/superglue/lib/utils/helpers.js → superglue/lib/utils/helpers.ts
diff --git a/superglue/lib/utils/immutability.js → superglue/lib/utils/immutability.ts b/superglue/lib/utils/immutability.js → superglue/lib/utils/immutability.ts
diff --git a/superglue/lib/utils/index.js → superglue/lib/utils/index.ts b/superglue/lib/utils/index.js → superglue/lib/utils/index.ts
diff --git a/superglue/lib/utils/react.js → superglue/lib/utils/react.ts b/superglue/lib/utils/react.js → superglue/lib/utils/react.ts
diff --git a/superglue/lib/utils/request.js → superglue/lib/utils/request.ts b/superglue/lib/utils/request.js → superglue/lib/utils/request.ts
diff --git a/superglue/lib/utils/ujs.js → superglue/lib/utils/ujs.ts b/superglue/lib/utils/ujs.js → superglue/lib/utils/ujs.ts
@@ -1,6 +1,10 @@
 import { withoutBusters, urlToPageKey } from './url'
 
 export class HandlerBuilder {
+  public attributePrefix: any
+  public visit: any
+  public remote: any
+
   constructor({ ujsAttributePrefix, visit, remote }) {
     this.attributePrefix = ujsAttributePrefix
     this.isUJS = this.isUJS.bind(this)
@@ -84,7 +88,7 @@ export class HandlerBuilder {
     this.visitOrRemote(link, url, { method: 'GET' })
   }
 
-  visitOrRemote(linkOrForm, url, opts = {}) {
+  visitOrRemote(linkOrForm, url, opts: any = {}) {
     let target
 
     if (linkOrForm.getAttribute(this.attributePrefix + '-visit')) {

diff --git a/superglue/lib/utils/url.js → superglue/lib/utils/url.ts b/superglue/lib/utils/url.js → superglue/lib/utils/url.ts
diff --git a/superglue/lib/utils/window.js → superglue/lib/utils/window.ts b/superglue/lib/utils/window.js → superglue/lib/utils/window.ts
diff --git a/superglue/package.json b/superglue/package.json
@@ -8,8 +8,10 @@
     "clean": "rm -rf ./dist",
     "copy:package": "cat ./package.json | jq 'del(.scripts)' > dist/package.json",
     "copy:readme": "cp ../README.md dist/",
-    "build:index": "babel lib -d dist",
-    "build": "npm run clean && npm run build:index && npm run copy:package && npm run copy:readme",
+    "build": "npm run clean && npm run build:js && npm run copy:package && npm run copy:readme",
+    "build:js": "babel lib --out-dir dist --extensions \".ts,.tsx\"",
+    "type-check": "tsc --noEmit",
+    "type-check:watch": "npm run type-check -- --watch",
     "prepublishOnly": "npm run build"
   },
   "repository": {
@@ -27,6 +29,7 @@
     "@babel/core": "^7.14.3",
     "@babel/preset-env": "^7.14.4",
     "@babel/preset-react": "^7.13.13",
+    "@babel/preset-typescript": "^7.24.6",
     "core-js": "^2.6.12",
     "enzyme": "^3.11.0",
     "enzyme-adapter-react-16": "^1.15.6",

diff --git a/superglue/tsconfig.json b/superglue/tsconfig.json
@@ -0,0 +1,12 @@
+{
+  "compilerOptions": {
+    "jsx": "react",
+    "allowJs": true,
+    "target": "es5",
+    "allowSyntheticDefaultImports": true,
+    "esModuleInterop": true
+  },
+  "include": [
+    "./lib/**/*"
+  ]
+}