Address review feedback

thompson-tomo · Sep 27, 2024 · 50a727c · 50a727c
1 parent 3bedb37
commit 50a727c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/...uration/src/CloudFoundry/ServiceBindings/PostProcessors/MySqlCloudFoundryPostProcessor.cs b/...uration/src/CloudFoundry/ServiceBindings/PostProcessors/MySqlCloudFoundryPostProcessor.cs
@@ -26,11 +26,9 @@ public override void PostProcessConfiguration(PostProcessorConfigurationProvider
             mapper.MapFromTo("credentials:name", "database");
             mapper.MapFromTo("credentials:username", "username");
             mapper.MapFromTo("credentials:password", "password");
-            // ReSharper disable StringLiteralTypo
-            mapper.MapFromToFile("credentials:sslcert", "ssl-cert");
-            mapper.MapFromToFile("credentials:sslkey", "ssl-key");
-            mapper.MapFromToFile("credentials:sslrootcert", "ssl-ca");
-            // ReSharper restore StringLiteralTypo
+            mapper.MapFromToFile("credentials:sslCert", "ssl-cert");
+            mapper.MapFromToFile("credentials:sslKey", "ssl-key");
+            mapper.MapFromToFile("credentials:sslRootCert", "ssl-ca");
         }
     }
 }
diff --git a/...on/src/CloudFoundry/ServiceBindings/PostProcessors/PostgreSqlCloudFoundryPostProcessor.cs b/...on/src/CloudFoundry/ServiceBindings/PostProcessors/PostgreSqlCloudFoundryPostProcessor.cs
@@ -25,11 +25,9 @@ public override void PostProcessConfiguration(PostProcessorConfigurationProvider
             mapper.MapFromTo("credentials:name", "database");
             mapper.MapFromTo("credentials:username", "username");
             mapper.MapFromTo("credentials:password", "password");
-            // ReSharper disable StringLiteralTypo
-            mapper.MapFromToFile("credentials:sslcert", "SSL Certificate");
-            mapper.MapFromToFile("credentials:sslkey", "SSL Key");
-            mapper.MapFromToFile("credentials:sslrootcert", "Root Certificate");
-            // ReSharper restore StringLiteralTypo
+            mapper.MapFromToFile("credentials:sslCert", "SSL Certificate");
+            mapper.MapFromToFile("credentials:sslKey", "SSL Key");
+            mapper.MapFromToFile("credentials:sslRootCert", "Root Certificate");
         }
     }
 }
diff --git a/src/Configuration/test/CloudFoundry.Test/ServiceBindings/PostProcessorsTest.cs b/src/Configuration/test/CloudFoundry.Test/ServiceBindings/PostProcessorsTest.cs
@@ -52,7 +52,7 @@ public void Processes_PostgreSql_configuration()
             Tuple.Create("credentials:password", "test-password"),
             Tuple.Create("credentials:sslCert", "test-ssl-cert"),
             Tuple.Create("credentials:sslKey", "test-ssl-key"),
-            Tuple.Create("credentials:sslRootCert", "test-ssl-root-cert")
+            Tuple.Create("credentials:sslrootcert", "test-ssl-root-cert") // tests case-insensitivity
         ];
 
         Dictionary<string, string?> configurationData =

diff --git a/...agement/test/Endpoint.Test/Actuators/HttpExchanges/HttpExchangesDiagnosticObserverTest.cs b/...agement/test/Endpoint.Test/Actuators/HttpExchanges/HttpExchangesDiagnosticObserverTest.cs
@@ -212,7 +212,7 @@ public void GetHttpExchanges_FiltersDuringReturn()
 
         optionsMonitor.CurrentValue.RequestHeaders.Add(HeaderNames.Authorization);
         optionsMonitor.CurrentValue.RequestHeaders.Add("header1");
-        optionsMonitor.CurrentValue.ResponseHeaders.Add("headerA");
+        optionsMonitor.CurrentValue.ResponseHeaders.Add("headera"); // tests case-insensitivity
         optionsMonitor.CurrentValue.ResponseHeaders.Add(HeaderNames.SetCookie);
 
         HttpExchange unfilteredHeaders = observer.GetHttpExchanges().Exchanges[0];