feat(hdom): add scrollTop/Left property support in setAttrib()

thi-ng · Feb 10, 2019 · 895da65 · 895da65
1 parent 3e48f6c
commit 895da65
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/hdom/src/dom.ts b/packages/hdom/src/dom.ts
@@ -232,7 +232,10 @@ export const setAttrib =
                 case "value":
                     updateValueAttrib(<HTMLInputElement>el, val);
                     break;
+                case "id":
                 case "checked":
+                case "scrollTop":
+                case "scrollLeft":
                     // TODO add more native attribs?
                     el[id] = val;
                     break;

diff --git a/packages/hdom/src/normalize.ts b/packages/hdom/src/normalize.ts
@@ -28,6 +28,9 @@ const isPlainObject = iso;
  * ["div.bar.baz", {class: "foo"}] => ["div", {class: "foo bar baz"}]
  * ```
  *
+ * Elements with `__skip` attrib enabled and no children, will have an
+ * empty text child element injected.
+ *
  * @param spec
  * @param keys
  */