fix(vectors): update minor()/major()

- update iteration order of default impls of both fns
thi-ng · Oct 5, 2023 · 88b3008 · 88b3008
1 parent 33c35b4
commit 88b3008
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/vectors/src/major.ts b/packages/vectors/src/major.ts
@@ -15,7 +15,7 @@ export const major: MultiVecOpRoV<number> = vop();
 major.default((a) => {
 	let id = -1;
 	let max = -Infinity;
-	for (let i = a.length; i-- > 0; ) {
+	for (let i = 0, n = a.length; i < n; i++) {
 		const x = abs(a[i]);
 		if (x > max) {
 			max = x;

diff --git a/packages/vectors/src/minor.ts b/packages/vectors/src/minor.ts
@@ -15,7 +15,7 @@ export const minor: MultiVecOpRoV<number> = vop();
 minor.default((a) => {
 	let id = -1;
 	let min = Infinity;
-	for (let i = a.length; i-- > 0; ) {
+	for (let i = 0, n = a.length; i < n; i++) {
 		const x = abs(a[i]);
 		if (x < min) {
 			min = x;