feat(webgl): add opt unbind flag for .configure()

- default remains true to keep existing behavior, but provide escape hatch where needed/useful (i.e. multipass stuff) - update impls for FBO, RBO, Texture
thi-ng · Aug 12, 2020 · 0e5cc2b · 0e5cc2b
1 parent cfce142
commit 0e5cc2b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/webgl/src/fbo.ts b/packages/webgl/src/fbo.ts
@@ -58,7 +58,7 @@ export class FBO implements IFbo {
         return true;
     }
 
-    configure(opts: Partial<FboOpts>) {
+    configure(opts: Partial<FboOpts>, unbind = true) {
         const gl = this.gl;
         this.bind();
         if (opts.tex) {
@@ -109,7 +109,7 @@ export class FBO implements IFbo {
                   );
         }
         this.validate();
-        return this.unbind();
+        return unbind ? this.unbind() : true;
     }
 
     validate() {

diff --git a/packages/webgl/src/rbo.ts b/packages/webgl/src/rbo.ts
@@ -30,7 +30,7 @@ export class RBO implements IRenderBuffer {
         return true;
     }
 
-    configure(opts: RboOpts) {
+    configure(opts: RboOpts, unbind = true) {
         const gl = this.gl;
         this.bind();
         this.format = opts.format || gl.DEPTH_COMPONENT16;
@@ -42,8 +42,7 @@ export class RBO implements IRenderBuffer {
             opts.width,
             opts.height
         );
-        this.unbind();
-        return true;
+        return unbind ? this.unbind() : true;
     }
 }
 

diff --git a/packages/webgl/src/texture.ts b/packages/webgl/src/texture.ts
@@ -34,7 +34,7 @@ export class Texture implements ITexture {
         this.configure(opts);
     }
 
-    configure(opts: Partial<TextureOpts> = {}) {
+    configure(opts: Partial<TextureOpts> = {}, unbind = true) {
         const gl = this.gl;
         const isGL2 = isGL2Context(gl);
         const target = opts.target || this.target || TextureTarget.TEXTURE_2D;
@@ -219,7 +219,7 @@ export class Texture implements ITexture {
             );
         }
 
-        gl.bindTexture(this.target, null);
+        unbind && gl.bindTexture(this.target, null);
 
         return true;
     }