chore: allow ts 5 as a peer dep #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
approved these changes
Sep 15, 2023
drbild
reviewed
Sep 15, 2023
package.json
Outdated
| @@ -26,7 +26,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "google-protobuf": "^3.13.0", | |||
| "typescript": "4.x.x" | |||
| "typescript": "4.x.x || 5.x.x" | |||
There was a problem hiding this comment.
I'd suggest >= 4.9.x instead, to exactly match the runtime check. It requires at least 4.9 and would allow a future 6.x.
There was a problem hiding this comment.
@drbild Good point - thanks. Updated.
|
Hi @thesayyn - Would it be possible to have an npm release for this to fix compatibility with TS >= 5? |
|
@thesayyn Thank you! 😄 |
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-pb-javascript
Oct 1, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [protoc-gen-ts](https://togithub.com/thesayyn/protoc-gen-ts) | devDependencies | patch | [`0.8.6` -> `0.8.7`](https://renovatebot.com/diffs/npm/protoc-gen-ts/0.8.6/0.8.7) | --- ### Release Notes <details> <summary>thesayyn/protoc-gen-ts (protoc-gen-ts)</summary> ### [`v0.8.7`](https://togithub.com/thesayyn/protoc-gen-ts/releases/tag/0.8.7) [Compare Source](https://togithub.com/thesayyn/protoc-gen-ts/compare/0.8.6...0.8.7) #### What's Changed - Fixed issue [#​178](https://togithub.com/thesayyn/protoc-gen-ts/issues/178) by [@​Aleksei2507](https://togithub.com/Aleksei2507) in [https://github.com/thesayyn/protoc-gen-ts/pull/208](https://togithub.com/thesayyn/protoc-gen-ts/pull/208) - Fixes issue [#​203](https://togithub.com/thesayyn/protoc-gen-ts/issues/203) by [@​danias](https://togithub.com/danias) in [https://github.com/thesayyn/protoc-gen-ts/pull/204](https://togithub.com/thesayyn/protoc-gen-ts/pull/204) - Using 0 instead of process.stdin.fd. by [@​YutaUra](https://togithub.com/YutaUra) in [https://github.com/thesayyn/protoc-gen-ts/pull/223](https://togithub.com/thesayyn/protoc-gen-ts/pull/223) - chore: allow ts 5 as a peer dep by [@​wdoconnell](https://togithub.com/wdoconnell) in [https://github.com/thesayyn/protoc-gen-ts/pull/226](https://togithub.com/thesayyn/protoc-gen-ts/pull/226) - refactor: deprecate index.bzl by [@​thesayyn](https://togithub.com/thesayyn) in [https://github.com/thesayyn/protoc-gen-ts/pull/229](https://togithub.com/thesayyn/protoc-gen-ts/pull/229) #### New Contributors - [@​Aleksei2507](https://togithub.com/Aleksei2507) made their first contribution in [https://github.com/thesayyn/protoc-gen-ts/pull/208](https://togithub.com/thesayyn/protoc-gen-ts/pull/208) - [@​danias](https://togithub.com/danias) made their first contribution in [https://github.com/thesayyn/protoc-gen-ts/pull/204](https://togithub.com/thesayyn/protoc-gen-ts/pull/204) - [@​YutaUra](https://togithub.com/YutaUra) made their first contribution in [https://github.com/thesayyn/protoc-gen-ts/pull/223](https://togithub.com/thesayyn/protoc-gen-ts/pull/223) - [@​wdoconnell](https://togithub.com/wdoconnell) made their first contribution in [https://github.com/thesayyn/protoc-gen-ts/pull/226](https://togithub.com/thesayyn/protoc-gen-ts/pull/226) **Full Changelog**: thesayyn/protoc-gen-ts@0.8.6...0.8.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #203, #225
Using the plugin with Typescript 5.x.x was previously blocked by an
ifblock that required that the TS major version be >= 4 and that the minor version be >=9 (the only 5.x.x Typescript versions have minor versions that are between 0 and 2). See #204. That fixed a portion of the issue, but the plugin is still not usable with Typescript 5.x.x due to a peer dependency restriction limiting it to use with Typescript 4.x.x.This adds TS 5.x.x as a potential peerdep.