Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IPAddr instead of manual IP arithmatic #52

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use IPAddr instead of manual IP arithmatic #52

wants to merge 1 commit into from
+14 −52

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 10, 2022

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Sep 13, 2022

This is passing for me on Ruby 3.1, but it looks like #netmask is actually a Ruby 3.1 feature.

@ekohl ekohl force-pushed the get-rid-of-ip-addr-arithmatic branch from b127602 to 7106a6a Compare September 15, 2022 14:27
@ekohl ekohl marked this pull request as draft September 15, 2022 14:27
@ekohl
Copy link
Member Author

ekohl commented Sep 15, 2022

Just a rebase to verify our new CI pipeline works as expected. And it does.

For now I've marked this as a draft since it requires Ruby 3.1+ and that's not realistic now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ekohl