Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary vertical space below posts if commends are disabled #662

Open
mikaelstaldal opened this issue Oct 28, 2023 · 0 comments
Open

Unnecessary vertical space below posts if commends are disabled #662

mikaelstaldal opened this issue Oct 28, 2023 · 0 comments
Milestone
unplanned

Comments

@mikaelstaldal
Copy link

In layouts/_default/single.html, there is a div for comments, which creates unnecessary (and IMHO annoying) vertical space if comments are disabled:

      <div class="mt6 instapaper_ignoref">
      {{ if .Site.DisqusShortname }}
        {{ template "_internal/disqus.html" . }}
      {{ end }}
      {{ if .Site.Params.commentoEnable }}
        {{- partial "commento.html" . -}}
      {{ end }}
      </div>

https://github.com/theNewDynamic/gohugo-theme-ananke/blob/master/layouts/_default/single.html#L53

I suggest that this div is only included if any comment system is enabled. Something like this:

      {{ if .Site.DisqusShortname }}
        <div class="mt6 instapaper_ignoref">
          {{ template "_internal/disqus.html" . }}
        </div>
      {{ end }}
      {{ if .Site.Params.commentoEnable }}
        <div class="mt6 instapaper_ignoref">
          {{- partial "commento.html" . -}}
        </div>
      {{ end }}
@davidsneighbour davidsneighbour added this to the unplanned milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
unplanned
Development

No branches or pull requests
2 participants
@davidsneighbour @mikaelstaldal