Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BKS65 Bolsa Supply PCB & Phantom by Lucid to VIA #407

Merged
merged 6 commits into from
Jan 11, 2021
Merged

Added BKS65 Bolsa Supply PCB & Phantom by Lucid to VIA #407

merged 6 commits into from
Jan 11, 2021

Conversation

mrnoisytiger
Copy link
Contributor

@mrnoisytiger mrnoisytiger commented Nov 13, 2020 •
edited
Loading

Description

Added upcoming Bolsa Supply BKS65 PCB to VIA

QMK Pull Request

qmk/qmk_firmware#10933 – BKS65
qmk/qmk_firmware#10988 – Phantom by Lucid

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Nov 16, 2020
@mrnoisytiger mrnoisytiger changed the title Added BKS65 Bolsa Supply PCB to VIA Added BKS65 Bolsa Supply PCB & Phantom by Lucid to VIA Nov 21, 2020
@mrnoisytiger
Copy link
Contributor Author

I screwed up and edited into master on my original branch, so boards got lumped into one pull request. Both are pending from merge from QMK. I have updated the original PR card to reflect both.

@mrnoisytiger
Copy link
Contributor Author

@Wilba6582 Both QMK PR's have been merged. Thanks!

@wilba wilba merged commit d094e75 into the-via:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrnoisytiger @wilba