Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve other bounds using PFR 9 #232

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

sgouezel
Copy link
Contributor

Improve the homomorphism version and approximate homomorphism version of PFR. It's not obvious if PFR 9 also gives an improvement for weak PFR over Z^d as the proof really uses the entropic control, which is not provided by the Kullback-Leibler divergence argument, so I haven't done anything there.

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

norm_cast

#print axioms better_PFR_conjecture

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, this examples file is very much broken. I guess it isn't tested by CI, and I'm not sure what its role is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is referenced on Terry's blog? It should very much be checked by CI!

@teorth
Copy link
Owner

teorth commented Nov 18, 2024

Yeah, it's supposed to allow someone with basic understanding of Lean, but not of the various technical definitions used in the PFR project, to be able to be convinced of the final results of the project. But it hasn't been maintained in months and so is indeed a bit broken. Were you able to get it to run with the latest build? If so we can try to explicitly import it in the master Lean file so that it is covered by CI going forward.

@YaelDillies
Copy link
Collaborator

we can try to explicitly import it in the master Lean file so that it is covered by CI going forward.

We will need to move it into the PFR folder (or another library folder. This will break links to it from your blog, which you will need to update. Will you be able to do that?

@YaelDillies YaelDillies merged commit 46706de into teorth:master Nov 19, 2024
2 checks passed
@teorth
Copy link
Owner

teorth commented Nov 19, 2024

Sure, will do. If you are willing to do the move as a PR I will update links accordingly.

@YaelDillies
Copy link
Collaborator

Here is the PR: #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants