Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p/pex: uses RWMutex in addrbook #6612

Closed
wants to merge 1 commit into from
Closed

p2p/pex: uses RWMutex in addrbook #6612

wants to merge 1 commit into from

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Jun 23, 2021 •
edited
Loading

Not sure what's the issue @melekes mentioned in #4848, But I looked at the addrmgr in btcd repo. The recent update relates to addrmgr was only using RWMutex instead of Mutex.

ref:
btcsuite/btcd#1697
https://github.com/btcsuite/btcd/blame/master/addrmgr

@tychoish
Copy link
Contributor

We're going to the addrbook immediately after the 0.35 release because it's part of the legacy p2p stack.

I'm inclined not to merge this, because it could change the timing of how peers connect (which works in the legacy stack at the moment,) and even if it's not optimal, the risk strikes me as bigger than average (particularly for code that we're inclined to delete in the next few months.)

@JayT106
Copy link
Contributor Author

JayT106 commented Jun 23, 2021 •
edited
Loading

We're going to the addrbook immediately after the 0.35 release because it's part of the legacy p2p stack.

I'm inclined not to merge this, because it could change the timing of how peers connect (which works in the legacy stack at the moment,) and even if it's not optimal, the risk strikes me as bigger than average (particularly for code that we're inclined to delete in the next few months.)

If this is the plan, I think the status of #4848 might need to be updated and then closes this PR.

@JayT106 JayT106 closed this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@cmwaters cmwaters Awaiting requested review from cmwaters

@ebuchman ebuchman Awaiting requested review from ebuchman

@tessr tessr Awaiting requested review from tessr

@tychoish tychoish Awaiting requested review from tychoish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayT106 @tychoish