more fixes from review

tendermint · jaekwon · Apr 17, 2015 · Apr 7, 2015 · Apr 7, 2015 · Apr 14, 2015
commit 65f669160fff441a807929ff443f19e3ad454933
diff --git a/events/event_cache.go b/events/event_cache.go
@@ -32,8 +32,10 @@ func (evc *EventCache) FireEvent(event string, msg interface{}) {
 }
 
 // Fire events by running evsw.FireEvent on all cached events. Blocks.
+// Clears cached events
 func (evc *EventCache) Flush() {
 	for _, ei := range evc.events {
 		evc.evsw.FireEvent(ei.event, ei.msg)
 	}
+	evc.events = make([]eventInfo, eventsBufferSize)
 }
diff --git a/node/node.go b/node/node.go
@@ -161,6 +161,10 @@ func (n *Node) MempoolReactor() *mempl.MempoolReactor {
 	return n.mempoolReactor
 }
 
+func (n *Node) EventSwitch() *events.EventSwitch {
+	return n.evsw
+}
+
 //------------------------------------------------------------------------------
 
 func RunNode() {

diff --git a/rpc/handlers.go b/rpc/handlers.go
@@ -212,8 +212,9 @@ type WSResponse struct {
 }
 
 // a single websocket connection
-// contains the listeners id
-type Connection struct {
+// contains listener id, underlying ws connection,
+// and the event switch for subscribing to events
+type WSConnection struct {
 	id          string
 	wsConn      *websocket.Conn
 	writeChan   chan WSResponse
@@ -225,16 +226,16 @@ type Connection struct {
 }
 
 // new websocket connection wrapper
-func NewConnection(wsConn *websocket.Conn) *Connection {
-	return &Connection{
+func NewWSConnection(wsConn *websocket.Conn) *WSConnection {
+	return &WSConnection{
 		id:        wsConn.RemoteAddr().String(),
 		wsConn:    wsConn,
 		writeChan: make(chan WSResponse, WriteChanBufferSize), // buffered. we keep track when its full
 	}
 }
 
 // start the connection and hand her the event switch
-func (con *Connection) Start(evsw *events.EventSwitch) {
+func (con *WSConnection) Start(evsw *events.EventSwitch) {
 	if atomic.CompareAndSwapUint32(&con.started, 0, 1) {
 		con.evsw = evsw
 
@@ -246,15 +247,29 @@ func (con *Connection) Start(evsw *events.EventSwitch) {
 }
 
 // close the connection
-func (con *Connection) Stop() {
+func (con *WSConnection) Stop() {
 	if atomic.CompareAndSwapUint32(&con.stopped, 0, 1) {
 		con.wsConn.Close()
 		close(con.writeChan)
 	}
 }
 
+// attempt to write response to writeChan and record failures
+func (con *WSConnection) safeWrite(resp WSResponse) {
+	select {
+	case con.writeChan <- resp:
+		// yay
+		con.failedSends = 0
+	default:
+		// channel is full
+		// if this happens too many times in a row,
+		// close connection
+		con.failedSends += 1
+	}
+}
+
 // read from the socket and subscribe to or unsubscribe from events
-func (con *Connection) read() {
+func (con *WSConnection) read() {
 	reaper := time.Tick(time.Second * WSConnectionReaperSeconds)
 	for {
 		select {
@@ -278,7 +293,7 @@ func (con *Connection) read() {
 			err = json.Unmarshal(in, &req)
 			if err != nil {
 				errStr := fmt.Sprintf("Error unmarshaling data: %s", err.Error())
-				con.writeChan <- WSResponse{Error: errStr}
+				con.safeWrite(WSResponse{Error: errStr})
 				continue
 			}
 			switch req.Type {
@@ -289,16 +304,7 @@ func (con *Connection) read() {
 						Event: req.Event,
 						Data:  msg,
 					}
-					select {
-					case con.writeChan <- resp:
-						// yay
-						con.failedSends = 0
-					default:
-						// channel is full
-						// if this happens too many times,
-						// close connection
-						con.failedSends += 1
-					}
+					con.safeWrite(resp)
 				})
 			case "unsubscribe":
 				if req.Event != "" {
@@ -307,15 +313,15 @@ func (con *Connection) read() {
 					con.evsw.RemoveListener(con.id)
 				}
 			default:
-				con.writeChan <- WSResponse{Error: "Unknown request type: " + req.Type}
+				con.safeWrite(WSResponse{Error: "Unknown request type: " + req.Type})
 			}
 
 		}
 	}
 }
 
 // receives on a write channel and writes out on the socket
-func (con *Connection) write() {
+func (con *WSConnection) write() {
 	n, err := new(int64), new(error)
 	for {
 		msg, more := <-con.writeChan
@@ -369,7 +375,7 @@ func (wm *WebsocketManager) websocketHandler(w http.ResponseWriter, r *http.Requ
 	}
 
 	// register connection
-	con := NewConnection(wsConn)
+	con := NewWSConnection(wsConn)
 	log.Info("New websocket connection", "origin", con.id)
 	con.Start(wm.evsw)
 }

diff --git a/rpc/test/helpers.go → rpc/test/helpers_test.go b/rpc/test/helpers.go → rpc/test/helpers_test.go
diff --git a/rpc/test/tests.go → rpc/test/tests_test.go b/rpc/test/tests.go → rpc/test/tests_test.go
diff --git a/rpc/test/ws_helpers.go → rpc/test/ws_helpers_test.go b/rpc/test/ws_helpers.go → rpc/test/ws_helpers_test.go
diff --git a/state/state.go b/state/state.go
@@ -101,6 +101,7 @@ func (s *State) Copy() *State {
 		UnbondingValidators:  s.UnbondingValidators.Copy(),  // copy the valSet lazily.
 		accounts:             s.accounts.Copy(),
 		validatorInfos:       s.validatorInfos.Copy(),
+		evc:                  nil,
 	}
 }
 

diff --git a/state/state_test.go b/state/state_test.go
@@ -12,7 +12,7 @@ import (
 
 func execTxWithState(state *State, tx types.Tx, runCall bool) error {
 	cache := NewBlockCache(state)
-	err := ExecTx(cache, tx, runCall, false)
+	err := ExecTx(cache, tx, runCall, nil)
 	if err != nil {
 		return err
 	} else {

diff --git a/vm/vm.go b/vm/vm.go
@@ -307,7 +307,6 @@ func (vm *VM) call(caller, callee *Account, code, input []byte, value uint64, ga
 			x, y := stack.Pop64(), stack.Pop64()
 			stack.Push64(x & y)
 			dbg.Printf(" %v & %v = %v\n", x, y, x&y)
-
 		case OR: // 0x17
 			x, y := stack.Pop64(), stack.Pop64()
 			stack.Push64(x | y)
@@ -381,7 +380,7 @@ func (vm *VM) call(caller, callee *Account, code, input []byte, value uint64, ga
 				return nil, firstErr(err, ErrInputOutOfBounds)
 			}
 			stack.Push(RightPadWord256(data))
-			dbg.Printf(" => 0x%X\n", data)
+			dbg.Printf(" => 0x%X\n", RightPadWord256(data))
 
 		case CALLDATASIZE: // 0x36
 			stack.Push64(uint64(len(input)))
@@ -721,10 +720,12 @@ func subslice(data []byte, offset, length uint64, flip_ bool) (ret []byte, ok bo
 	if size < offset {
 		return nil, false
 	} else if size < offset+length {
-		ret, ok = data[offset:], false
+		ret, ok = data[offset:], true
+		ret = RightPadBytes(ret, 32)
 	} else {
 		ret, ok = data[offset:offset+length], true
 	}
+
 	if flip_ {
 		ret = flip(ret)
 	}