Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No kubebuilder #66

Merged
merged 2 commits into from
Sep 26, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix resource version
In our first iteration of the API, we were using `v1beta1` as the
version. We bumped this to `v1alpha1` while removing kubebuilder but
didn't update it everywhere.

Also removed extra references to git-init and creds-init (at the moment we
aren't building these from anything in this repo)

Co-authored-by: Tejal Desai <tejaldesai@google.com>
  • Loading branch information
2 people authored and aaron-prindle committed Sep 26, 2018
commit 867cabf31189e14777504d61881cfbd8401f0f43
3 changes: 0 additions & 3 deletions .ko.yaml

This file was deleted.

5 changes: 1 addition & 4 deletions config/200-clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,5 @@ rules:
resources: ["customresourcedefinitions"]
verbs: ["get", "list", "create", "update", "delete", "patch", "watch"]
- apiGroups: ["pipeline.knative.dev"]
resources: ["builds", "buildtemplates", "clusterbuildtemplates"]
resources: ["tasks", "taskruns", "pipelines", "pipelineruns", "pipelineparams", "resources"]
verbs: ["get", "list", "create", "update", "delete", "patch", "watch"]
- apiGroups: ["caching.internal.knative.dev"]
resources: ["images"]
verbs: ["get", "list", "create", "update", "delete", "deletecollection", "patch", "watch"]
2 changes: 1 addition & 1 deletion config/300-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ spec:
status:
type: object
type: object
version: v1beta1
version: v1alpha1
status:
acceptedNames:
kind: ""
Expand Down
2 changes: 1 addition & 1 deletion config/300-pipelineparams.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
status:
type: object
type: object
version: v1beta1
version: v1alpha1
status:
acceptedNames:
kind: ""
Expand Down
2 changes: 1 addition & 1 deletion config/300-pipelinerun.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ spec:
- conditions
type: object
type: object
version: v1beta1
version: v1alpha1
status:
acceptedNames:
kind: ""
Expand Down
2 changes: 1 addition & 1 deletion config/300-resource.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ spec:
status:
type: object
type: object
version: v1beta1
version: v1alpha1
status:
acceptedNames:
kind: ""
Expand Down
2 changes: 1 addition & 1 deletion config/300-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ spec:
status:
type: object
type: object
version: v1beta1
version: v1alpha1
status:
acceptedNames:
kind: ""
Expand Down
2 changes: 1 addition & 1 deletion config/300-taskrun.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ spec:
- conditions
type: object
type: object
version: v1beta1
version: v1alpha1
status:
acceptedNames:
kind: ""
Expand Down
2 changes: 0 additions & 2 deletions config/config-logging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,3 @@ data:
# Log level overrides
loglevel.controller: "info"
loglevel.webhook: "info"
loglevel.creds-init: "info"
loglevel.git-init: "info"
2 changes: 0 additions & 2 deletions config/controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ spec:
args: [
"-logtostderr",
"-stderrthreshold", "INFO",
"-creds-image", "github.com/knative/build-pipeline/cmd/creds-init",
"-git-image", "github.com/knative/build-pipeline/cmd/git-init",
]
volumeMounts:
- name: config-logging
Expand Down
4 changes: 2 additions & 2 deletions examples/deploy_tasks.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: deploy-with-helm
Expand All @@ -25,7 +25,7 @@ spec:
args: ['deploy', '--path=${pathToHelmChart}', '--set image=${image}', '${helmArgs}']

---
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: deploy-with-kubectl
Expand Down
2 changes: 1 addition & 1 deletion examples/invocations/kritis-pipeline-run.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineRun
metadata:
name: kritis-pipeline-run-12321312984
Expand Down
2 changes: 1 addition & 1 deletion examples/invocations/run-kritis-test.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: TaskRun
metadata:
labels:
Expand Down
2 changes: 1 addition & 1 deletion examples/pipelineparams.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineParams
metadata:
name: pipelineparams-sample
Expand Down
2 changes: 1 addition & 1 deletion examples/pipelines/guestbook-resources.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Resource
metadata:
name: guestbook-resources-sample
Expand Down
2 changes: 1 addition & 1 deletion examples/pipelines/guestbook.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Pipeline
metadata:
name: guestbook-example
Expand Down
2 changes: 1 addition & 1 deletion examples/pipelines/kritis-resources.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Resource
metadata:
name: kritis-resources-sample
Expand Down
2 changes: 1 addition & 1 deletion examples/pipelines/kritis.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Pipeline
metadata:
name: kritis-pipeline
Expand Down
4 changes: 2 additions & 2 deletions examples/test_tasks.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: make
Expand All @@ -24,7 +24,7 @@ spec:
args: ['make', '${makeTarget}']

---
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: integration-test-in-docker
Expand Down
8 changes: 4 additions & 4 deletions samples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

These are samples to demonstrate how the Pipeline CRD is intended to work.

These samples are also duplicated in Go in the type tests in [./pkg/apis/pipeline/v1beta1](./pkg/apis/pipeline/v1beta1),
These samples are also duplicated in Go in the type tests in [./pkg/apis/pipeline/vqalpha1](./pkg/apis/pipeline/v1alpha1),
if updating these samples please update the tests too.

This includes samples of:

* [A pipeline](pipeline_v1beta1_pipeline.yaml)
* [A task used in that pipeline](pipeline_v1beta1_task.yaml)
* [Parameters to the pipeline](pipeline_v1beta1_pipelineparams.yaml)
* [A pipeline](pipeline_v1alpha1_pipeline.yaml)
* [A task used in that pipeline](pipeline_v1alpha1_task.yaml)
* [Parameters to the pipeline](pipeline_v1alpha1_pipelineparams.yaml)
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Pipeline
metadata:
name: wizzbang-pipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineParams
metadata:
name: wizzbang-pipeline-params
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineRun
metadata:
name: wizzbang-pipeline-run-sd8f8dfasdfasdfas
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: build-push-task
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: pipeline.knative.dev/v1beta1
apiVersion: pipeline.knative.dev/v1alpha1
kind: TaskRun
metadata:
name: integration-test-wizzbang-task-run-sd8f8dfasdfasdfas
Expand Down