Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action for the PR build tests #3839

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add GitHub Action for the PR build tests #3839

merged 1 commit into from
Jan 6, 2025

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Dec 11, 2024 •
edited
Loading

Changes

This includes:

  • gofmt
  • yamllint
  • building the go code
  • license check
  • golangci-lint

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2024
@AlanGreene AlanGreene marked this pull request as draft December 11, 2024 17:57
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@AlanGreene AlanGreene force-pushed the gha_pr_build branch 6 times, most recently from 8e36da8 to 5612d3c Compare December 11, 2024 18:48
@AlanGreene AlanGreene mentioned this pull request Dec 11, 2024
Merged
7 tasks
@AlanGreene AlanGreene marked this pull request as ready for review December 13, 2024 00:19
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@tekton-robot tekton-robot requested a review from skaegi December 13, 2024 00:19
@AlanGreene AlanGreene removed the request for review from skaegi December 16, 2024 00:51
@AlanGreene
Add GitHub Actions workflow for the PR build tests
5e7883c 
This includes:
- gofmt
- yamllint
- building the go code
- license check
- golangci-lint
@AlanGreene AlanGreene mentioned this pull request Dec 16, 2024
Merged
7 tasks
briangleeson
briangleeson approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@AlanGreene
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit cec866e into tektoncd:main Jan 6, 2025
14 checks passed
@AlanGreene AlanGreene deleted the gha_pr_build branch January 6, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson briangleeson approved these changes

@LyndseyBu LyndseyBu Awaiting requested review from LyndseyBu

Assignees

@briangleeson briangleeson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGreene @tekton-robot @briangleeson