Match fieldsets which contain the locator in legend child elements.

teamcapybara · Oct 31, 2010 · 21e7b3a · 21e7b3a
1 parent 80fbaf4
commit 21e7b3a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/lib/xpath/html.rb b/lib/xpath/html.rb
@@ -23,7 +23,7 @@ def link_or_button(locator)
     end
 
     def fieldset(locator)
-      descendant(:fieldset)[attr(:id).equals(locator) | descendant(:legend)[text.is(locator)]]
+      descendant(:fieldset)[attr(:id).equals(locator) | descendant(:legend)[string.n.is(locator)]]
     end
 
     def field(locator, options={})

diff --git a/spec/fixtures/form.html b/spec/fixtures/form.html
@@ -59,6 +59,7 @@ <h1>Form</h1>
 <p>
   <fieldset id="some-fieldset-id" data="fieldset-id"></fieldset>
   <fieldset data="fieldset-legend"><legend>Some Legend</legend></fieldset>
+  <fieldset data="fieldset-legend-span"><legend><span>Span Legend</span></legend></fieldset>
   <fieldset data="fieldset-fuzzy"><legend>Long legend yo</legend></fieldset>
   <fieldset data="fieldset-exact"><legend>Long legend</legend></fieldset>
 </p>
diff --git a/spec/html_spec.rb b/spec/html_spec.rb
@@ -81,10 +81,11 @@ def all(*args)
   describe '#fieldset' do
     subject { :fieldset }
 
-    it("finds fieldsets by id")       { get('some-fieldset-id').should == 'fieldset-id' }
-    it("finds fieldsets by legend")   { get('Some Legend').should == 'fieldset-legend' }
-    it("accepts approximate legends") { get('Legend').should == 'fieldset-legend' }
-    it("prefers exact legend")        { all('Long legend').should == ['fieldset-exact', 'fieldset-fuzzy'] }
+    it("finds fieldsets by id")                  { get('some-fieldset-id').should == 'fieldset-id' }
+    it("finds fieldsets by legend")              { get('Some Legend').should == 'fieldset-legend' }
+    it("finds fieldsets by legend child tags")   { get('Span Legend').should == 'fieldset-legend-span' }
+    it("accepts approximate legends")            { get('Legend').should == 'fieldset-legend' }
+    it("prefers exact legend")                   { all('Long legend').should == ['fieldset-exact', 'fieldset-fuzzy'] }
   end
 
   describe '#field' do