Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorama.just_fix_windows_console() #352

Merged
merged 9 commits into from
Oct 17, 2022
+183 −37
Merged

Add colorama.just_fix_windows_console() #352

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5f1794d
Add colorama.just_fix_windows_console()
njsmith Oct 17, 2022
bab6f93
init->just_fix_windows_console in all demos that call bare init()
njsmith Oct 17, 2022
66b76ed
Remove broken test
njsmith Oct 17, 2022
3f3c06a
Fix test on Win10
njsmith Oct 17, 2022
3c5553f
Be more thorough about cleaning up state between tests
njsmith Oct 17, 2022
479da74
Work around a bunch of spurious test failures
njsmith Oct 17, 2022
38b498a
Add test for just_fix_windows_console
njsmith Oct 17, 2022
1a82924
Workaround py2's lack of atexit.unregister
njsmith Oct 17, 2022
78bce18
Refactor test and make it work in CI (no console)
njsmith Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove broken test 
This test never actually tested what it claimed to, and it's broken on Win10, so just remove it.
@njsmith
njsmith committed Oct 17, 2022
commit 66b76eda602c87973fa25a776476d79be7d7fab7
8 changes: 0 additions & 8 deletions colorama/tests/initialise_test.py
View file
Original file line number Diff line number Diff line change
@@ -78,14 +78,6 @@ def testInitWrapOffDoesntWrapOnWindows(self):
def testInitWrapOffIncompatibleWithAutoresetOn(self):
self.assertRaises(ValueError, lambda: init(autoreset=True, wrap=False))

@patch('colorama.ansitowin32.winterm', None)
@patch('colorama.ansitowin32.winapi_test', lambda *_: True)
def testInitOnlyWrapsOnce(self):
with osname("nt"):
init()
init()
self.assertWrapped()

@patch('colorama.win32.SetConsoleTextAttribute')
@patch('colorama.initialise.AnsiToWin32')
def testAutoResetPassedOn(self, mockATW32, _):