flake.nix: use ./tool instead of nixpkgs #14510
Open
+22
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensure consistency between tooling used by nix and non-nix users. Updates tailscale/corp#25620 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Remove the check if the shell is Nix based, it looks for a nix store path, which on nix-darwin will not start with /nix/store (but /etc/profile). ./tool/helm is no used regardless of nix, and nix shell is using that since prev commit. Updates #25620 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
irbekrm
reviewed
Jan 6, 2025
There was a problem hiding this comment.
./tool/helm is no used regardless of nix
For context, ./too/helm exists so that our release scripts that run on the build server can run helm commands to package helm charts without us needing to install helm CLI there, i.e https://github.com/tailscale/corp/blob/main/misc/build/clients/helmchart.go#L21 (private link)
I think the build servers are still using nix shell? But I might be wrong, I haven't looked at the setup there for a while
|
FYI there is also Line 32 in 2fb361a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensure consistency between tooling used by nix and non-nix users.
Updates tailscale/corp#25620
Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com