Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various issues when running make vet make lint #14492

Closed
MarcPaquette opened this issue Dec 29, 2024 · 0 comments
Closed

Various issues when running make vet make lint #14492

MarcPaquette opened this issue Dec 29, 2024 · 0 comments
Labels
bug Bug needs-triage

Comments

@MarcPaquette
Copy link

What is the issue?

When running the make commands to vet & lint the repository, various error occur

Steps to reproduce

Running make vet results in the following warnings:

mp$ make vet
./tool/go vet ./...
# tailscale.com/client/tailscale
# [tailscale.com/client/tailscale]
client/tailscale/localclient.go:558:27: cmp.Or requires go1.22 or later (file is go1.21)
# tailscale.com/wgengine/filter
# [tailscale.com/wgengine/filter]
wgengine/filter/filter_test.go:771:9: tailscale.com/wgengine/filter/filtertype.PortRange struct literal uses unkeyed fields
wgengine/filter/filter_test.go:817:15: tailscale.com/wgengine/filter/filtertype.PortRange struct literal uses unkeyed fields
wgengine/filter/filter_test.go:821:15: tailscale.com/wgengine/filter/filtertype.PortRange struct literal uses unkeyed fields
wgengine/filter/filter_test.go:851:15: tailscale.com/wgengine/filter/filtertype.PortRange struct literal uses unkeyed fields
make: *** [Makefile:9: vet] Error 1

Running make lint generates the following warnings:

mp$ make lint
./tool/go run github.com/golangci/golangci-lint/cmd/golangci-lint run
# github.com/golangci/golangci-lint/cmd/golangci-lint
/usr/bin/ld: /tmp/go-link-2906064484/000001.o: in function `pluginOpen':
/_/GOROOT/src/plugin/plugin_dlopen.go:19:(.text+0x86): warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
wgengine/netstack/gro/gro.go:8: File is not `goimports`-ed (goimports)
        "bytes"
wgengine/filter/filter_test.go:771:9: composites: tailscale.com/wgengine/filter.PortRange struct literal uses unkeyed fields (govet)
        return PortRange{uint16(first), uint16(last)}
               ^
wgengine/filter/filter_test.go:817:15: composites: tailscale.com/wgengine/filter.PortRange struct literal uses unkeyed fields (govet)
                                                        Ports: PortRange{22, 22},
                                                               ^
wgengine/filter/filter_test.go:821:15: composites: tailscale.com/wgengine/filter.PortRange struct literal uses unkeyed fields (govet)
                                                        Ports: PortRange{22, 22},
                                                               ^
exit status 1
make: *** [Makefile:15: lint] Error 1

Are there any recent changes that introduced the issue?

No response

OS

Linux

OS version

Ubuntu 24.04.1 LTS

Tailscale version

Working off of the main branch

Other software

No response

Bug report

No response
MarcPaquette pushed a commit to MarcPaquette/tailscale that referenced this issue Dec 29, 2024
Fix various linting, vet & static check issues
5b26108 
Fixes tailscale#14492

-----

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Marc Paquette <marcphilippaquette@gmail.com>
bradfitz pushed a commit to MarcPaquette/tailscale that referenced this issue Jan 4, 2025
@bradfitz
Fix various linting, vet & static check issues
bd7126f 
Fixes tailscale#14492

-----

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Change-Id: I6dc1068d34bbfa7477e7b7a56a4325b3868c92e1
Signed-off-by: Marc Paquette <marcphilippaquette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug needs-triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcPaquette