add ability to turn off logging from client

tadgem · Jul 17, 2024 · bf01a95 · bf01a95
1 parent 18e2f9a
commit bf01a95
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 11 deletions.
diff --git a/backends/sdl/include/VulkanAPI_SDL.h b/backends/sdl/include/VulkanAPI_SDL.h
@@ -13,6 +13,7 @@ namespace lvk {
 	class VulkanAPI_SDL : public VulkanAPI
 	{
 	public:
+        VulkanAPI_SDL(bool enableDebugValidation = true);
 		virtual ~VulkanAPI_SDL();
 		void 								HandleSDLEvent(SDL_Event& sdl_event);
 		// Inherited via VulkanAPI

diff --git a/backends/sdl/src/VulkanAPI_SDL.cpp b/backends/sdl/src/VulkanAPI_SDL.cpp
@@ -170,6 +170,11 @@ VkExtent2D lvk::VulkanAPI_SDL::GetMaxFramebufferResolution()
     return res;
 }
 
+lvk::VulkanAPI_SDL::VulkanAPI_SDL(bool enableDebugValidation) : VulkanAPI(enableDebugValidation)
+{
+
+}
+
 lvk::VulkanAPIWindowHandle_SDL::VulkanAPIWindowHandle_SDL(SDL_Window* sdlWindow) : m_SdlWindow(sdlWindow)
 {
 

diff --git a/lvk/include/lvk/VulkanAPI.h b/lvk/include/lvk/VulkanAPI.h
@@ -136,6 +136,8 @@ namespace lvk
         const bool                  m_UseValidation = true;
         const bool                  m_UseImGui      = true;
 
+        VulkanAPI(bool enableDebugValidation);
+
 
         enum class ShaderStage
         {

diff --git a/lvk/src/lvk/VulkanAPI.cpp b/lvk/src/lvk/VulkanAPI.cpp
@@ -171,20 +171,23 @@ void lvk::VulkanAPI::CreateInstance()
 
     std::vector<const char*> extensionNames = GetRequiredExtensions();
 
-    for (const auto& extension : extensionNames)
-    {
-        spdlog::info("SDL Extension : {}", extension);
+    if(m_UseValidation) {
+        for (const auto &extension: extensionNames) {
+            spdlog::info("Backend Extension : {}", extension);
+        }
     }
-
     uint32_t extensionCount;
     vkEnumerateInstanceExtensionProperties(nullptr, &extensionCount, nullptr);
     std::vector<VkExtensionProperties> extensions(extensionCount);
     vkEnumerateInstanceExtensionProperties(nullptr, &extensionCount, extensions.data());
 
-    spdlog::info("Supported m_Instance extensions: ");
-    for (const auto& extension : extensions)
-    {
-        spdlog::info("{}", &extension.extensionName[0]);
+    if(m_UseValidation) {
+        spdlog::info("Supported m_Instance extensions: ");
+    }
+    for (const auto& extension : extensions) {
+        if (m_UseValidation) {
+            spdlog::info("{}", &extension.extensionName[0]);
+        }
         bool shouldAdd = true;
         for (int i = 0; i < extensionNames.size(); i++)
         {
@@ -447,9 +450,10 @@ void lvk::VulkanAPI::PickPhysicalDevice()
     VkPhysicalDeviceProperties deviceProperties{};
     vkGetPhysicalDeviceProperties(m_PhysicalDevice, &deviceProperties);
 
-    spdlog::info("Chose GPU : {}", &deviceProperties.deviceName[0]);
-    ListDeviceExtensions(m_PhysicalDevice);
-
+    if(m_UseValidation) {
+        spdlog::info("Chose GPU : {}", &deviceProperties.deviceName[0]);
+        ListDeviceExtensions(m_PhysicalDevice);
+    }
 }
 
 void lvk::VulkanAPI::CreateLogicalDevice()
@@ -2507,3 +2511,8 @@ void lvk::VulkanAPI::CleanupImGui()
     }
 }
 
+VulkanAPI::VulkanAPI(bool enableDebugValidation) : m_UseValidation(enableDebugValidation)
+{
+
+}
+
-Original file line number
+Diff line change
@@ Expand Up @@
         return res;
     }
+    lvk::VulkanAPI_SDL::VulkanAPI_SDL(bool enableDebugValidation) : VulkanAPI(enableDebugValidation)
+    {
+    }
     lvk::VulkanAPIWindowHandle_SDL::VulkanAPIWindowHandle_SDL(SDL_Window* sdlWindow) : m_SdlWindow(sdlWindow)
     {
@@ Expand Down @@