Made DynamicSpriteFont.SpriteCharacterData public #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new feature?
SpriteCharacterData can now be accessed outside of DynamicSpriteFont.
_spriteCharacters and _defaultCharacterData were given accessor properties.
Why should this be part of tModLoader?
Currently creating or manipulating fonts with code in any way requires heavy use of reflection, while doing so is not widely useful, those mods which do have use for it currently must sacrifice all manner of compile-time error checking in all code involving it.
Are there alternative designs?
_spriteCharacters and/or _defaultCharacterData could be made public instead of being given accessor properties.