Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla backgrounds and blood moons always override water styles #4481

Open
Tyfyter opened this issue Dec 16, 2024 · 0 comments
Open

Vanilla backgrounds and blood moons always override water styles #4481

Tyfyter opened this issue Dec 16, 2024 · 0 comments
Labels
NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. Requestor-Modders Issues or PRs adding or fixing TML modder API

Comments

@Tyfyter
Copy link
Contributor

Tyfyter commented Dec 16, 2024

Version

Latest 1.4.4-stable

OS

Windows

Platform

Steam

This bug affects...

Mod capability as a Modder

Description

Scene effects are not involved in determining water styles if the background style is 1, 2, 3, 4, 5, 6, 7, or 8, or if a blood moon is active.

Steps to reproduce

  1. create any scene effect which changes the water style but not the background and give it a high priority (as one would do when implementing blood moons were they not a vanilla feature).
  2. fulfill the conditions for the scene effect to be active while in any of the biomes associated with one of the listed background styles, such as the desert.

Expected Behavior

The scene effect should change the water style to its own.

Actual Behavior

The vanilla water style is kept despite a scene effect with a supposedly higher priority than the biome it's from being active.

@Tyfyter Tyfyter added the NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. label Dec 16, 2024
@github-actions github-actions bot added the Requestor-Modders Issues or PRs adding or fixing TML modder API label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. Requestor-Modders Issues or PRs adding or fixing TML modder API
Projects
None yet
Development

No branches or pull requests

1 participant