Version

Latest 1.4.4-stable

OS

Windows

Platform

Steam

This bug affects...

Mod capability as a Modder

Description

When a vanilla item's name has been overridden using Item.SetNameOverride(), rolling over that item in the Journey Mode duplication menu causes all other items in the duplication menu to have the same name.

Log File

client.log
Launch.log
Natives.log
environment-client.log

Steps to reproduce

1. Load a mod with code in it like this:

public class ItemNameOverrider : GlobalItem {
    public override void SetDefaults(Item item) {
        if (item.type == ItemID.CopperBar) {
            item.SetNameOverride("Renamed copper bar");
        }
    }
}

2. Enter a world in Journey Mode in single-player.
3. Open the duplication menu and roll over various items with the mouse. Of course, they each show their own names.
4. Find copper bar and roll over it. It shows its new name "Renamed copper bar".
5. Now roll over various other items in the duplication menu.

Expected Behavior

The other items still show their vanilla name.

Actual Behavior

After rolling over the copper bar, all items in the duplication menu display their name as "Renamed copper bar", and this persists until you exit the world. (Other attributes like tooltips and rarity are unaffected.) If you put items in your inventory from the duplication menu, they will keep their erroneously modified names.

Reproduction frequency

Consistently, I guess. I disabled all mods other than mine and it still was reproducible.

Additional Information

If my code is actually just wrong, please let me know.