Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gitignore #68

Merged
merged 2 commits into from
Oct 22, 2022
Merged

Add gitignore #68

merged 2 commits into from
Oct 22, 2022

Conversation

hay-kot
Copy link
Contributor

@hay-kot hay-kot commented Oct 1, 2022

Heyo! Not sure if it was intentional to leave out a git ignore or not. I added one with some sensible defaults.

@szabodanika
Copy link
Owner

Hey hey, should we perhaps add Cargo.lock and pasta_data/ as well?

@hay-kot
Copy link
Contributor Author

hay-kot commented Oct 22, 2022

I've added pasta_data/*

According to cargo if you're building a binary you should include the lock file in source control. ultimately up to you.

https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

@szabodanika
Copy link
Owner

You're absolutely right, let's keep Cargo.lock

@szabodanika szabodanika merged commit 2e981b3 into szabodanika:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hay-kot @szabodanika