Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named-exports extras - Default export function with named exports #2186

Merged
merged 9 commits into from
May 9, 2020
Merged

Named-exports extras - Default export function with named exports #2186

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc071e2
Allow default function to have named-exports
Sauloxd May 8, 2020
13605eb
Updated dist bundle
Sauloxd May 8, 2020
62dac82
Add tests for umd named exports
Sauloxd May 8, 2020
b3d8d28
Revert dist changes
Sauloxd May 9, 2020
f0c28ec
created fixture for Object.create(null)
Sauloxd May 9, 2020
a7fc382
Linters :shirt:
Sauloxd May 9, 2020
69478b7
Check for enumerable safe for Object.creaate(null)
Sauloxd May 9, 2020
932f417
Add tests for default export w Obj.create(null)
Sauloxd May 9, 2020
88659ec
:shirt:
Sauloxd May 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for default export w Obj.create(null)
  • Loading branch information
@Sauloxd
Sauloxd committed May 9, 2020
commit 932f41722a7f5317814411f85662a2b20ab065fc
10 changes: 10 additions & 0 deletions test/browser/named-exports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ suite('Named exports', function () {
assert.ok(m.default);
assert.equal(m.dep, m.default.dep);
assert.equal(m.umd, true);
assert.equal(m.default.hasOwnProperty, Object.prototype.hasOwnProperty)
});
});

test('Loading an UMD module with default with object null prototype', function () {
return System.import('fixtures/umd-default-object-with-null-prototype-module.js').then(function (m) {
assert.ok(m.default);
assert.equal(m.dep, m.default.dep);
assert.equal(m.umd, true);
assert.equal(m.default.hasOwnProperty, undefined)
});
});

Expand Down