Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support registry delete returning update function #2020

Merged
merged 6 commits into from
Oct 20, 2019
Merged

Support registry delete returning update function #2020

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c83dccd
support registry delete returning update function
guybedford Sep 3, 2019
9c5e7f4
continue to allow set for existing loads
guybedford Sep 4, 2019
f8094d9
fixup importerSetters reference
guybedford Sep 7, 2019
c84e9b8
remove setters check, ensure update runs once
guybedford Sep 7, 2019
d2a9336
Update src/features/registry.js
guybedford Sep 11, 2019
c52a9a4
ensure L and I are undefined for System.set
guybedford Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/features/registry.js 
Co-Authored-By: Lars den Bakker <larsdenbakker@gmail.com>
  • Loading branch information
@guybedford @LarsDenBakker
guybedford and LarsDenBakker authored Sep 11, 2019
commit d2a9336598b7c5d7180139ba28d598ed7ffef656
2 changes: 1 addition & 1 deletion src/features/registry.js
View file
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ systemJSPrototype.delete = function (id) {
// add back the old setters
importerSetters.forEach(setter => {
load.i.push(setter);
setter(load.ns);
setter(load.n);
});
importerSetters = null;
};