Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deps argument to onload hook #1998

Merged
merged 2 commits into from
Aug 25, 2019
Merged

Add deps argument to onload hook #1998

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0f9e6e
update onload hook with deps
guybedford Aug 25, 2019
7ff8780
update error explanation
guybedford Aug 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update error explanation
  • Loading branch information
@guybedford
guybedford committed Aug 25, 2019
commit 7ff87803af139e7de0371d8267e27171176b4a6f
2 changes: 1 addition & 1 deletion docs/hooks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ _This hook is not available in the s.js minimal loader build._

For tracing functionality this is called on completion or failure of each and every module loaded into the registry.

`err` is defined for any module load error - instantiation (including fetch) errors, execution errors and dependency errors.
`err` is defined for any module load error at instantiation (including fetch and resolution errors), execution or dependency execution.

`deps` is available for errored modules that did not error on instantiation.

Expand Down