s3: add comment about workaround

Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
syslog-ng · Oct 2, 2024 · a84fd2d · a84fd2d
1 parent 8fed43f
commit a84fd2d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/modules/python-modules/syslogng/modules/s3/s3_destination.py b/modules/python-modules/syslogng/modules/s3/s3_destination.py
@@ -249,6 +249,9 @@ def open(self) -> bool:
         if self.is_opened():
             return True
 
+        # NOTE: Creating a client via a Session object does some unusual caching, which increases memory usage
+        # NOTE: each reload.  Because of this, we only create Session object if the role is set, and in that case
+        # NOTE: the memory usage is expected to behave unusually.  Sometime we should investigate this further.
         if self.role != "":
             self.session = Session(
                 aws_access_key_id=self.access_key if self.access_key != "" else None,