Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of tree should be Node? #6

Closed
4 tasks done
agoose77 opened this issue Oct 29, 2024 · 3 comments
Closed
4 tasks done

Type of tree should be Node? #6

agoose77 opened this issue Oct 29, 2024 · 3 comments
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Comments

@agoose77
Copy link

Initial checklist

Affected packages and versions

latest

Link to runnable example

No response

Steps to reproduce

Passing in a Node type to findAndReplace causes tsc to complain. Yet, it appears from the call to visitParents that tree should really be Node, not Nodes.

Expected behavior

The compilation should succeed

Actual behavior

The compiler complains

Affected runtime and version

node@22.6.0, typescript@5.6.3

Affected package manager and version

No response

Affected OS and version

No response

Build and bundle tools

No response
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 29, 2024
@wooorm
Copy link
Member

wooorm commented Oct 29, 2024

Nope! Node is abstract. You should not use it. Use concrete types

@wooorm wooorm closed this as completed Oct 29, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@agoose77
Copy link
Author

@wooorm thanks!

@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Oct 29, 2024
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wooorm @agoose77