Implemented some series methods for gamma and error functions #26214
Conversation
|
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13. Click here to see the pull request description that was parsed. |
|
So the main problem here is that you haven't written pull request properly |
| arg0 = arg.subs(x, 0) | ||
|
|
||
| if arg0 is S.NaN: | ||
| arg0 = arg.limit(x, 0, dir='-' if re(cdir).is_negative else '+') |
There was a problem hiding this comment.
some thoughts over the code:
arg0 = arg.limit(x, 0, dir='-' if re(cdir).is_negative else '+')
maybe it's better to move dir calculation to temp variable to make it more readable
| def _eval_rewrite_as_expint(self, s, x, **kwargs): | ||
| from sympy.functions.special.error_functions import expint | ||
| if s.is_integer and s.is_nonpositive: | ||
| return self | ||
| return self.rewrite(uppergamma).rewrite(expint) | ||
|
|
||
| def _eval_as_leading_term(self, x, logx=None, cdir=0): | ||
| return self.rewrite(uppergamma)._eval_as_leading_term(x, logx=logx, cdir=cdir) | ||
|
|
| def _eval_as_leading_term(self, x, logx=None, cdir=0): | ||
| from sympy.functions.special.error_functions import expint | ||
| return self.rewrite(expint)._eval_as_leading_term(x, logx=logx, cdir=cdir) | ||
|
|
|
Also please fix the code quality. I think you might have to pull the latest changes and rebase on top of it. |
Abhishekjsr283204
force-pushed
the
JSR
branch
from
71bafb3 to
7294cbe
Compare
References to other Issues or PRs
Brief description of what is fixed or changed
While implementing the leading term for expint(nu, z) function, we don't have to take care of cases where nu < 1, and as the already implemented _eval_nseries method shows we essentially only need to focus on cases where nu >=1.
Because expint(nu, z) when nu < 1 will be rewritten in the forms of exponentials.
Other comments