Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded code and replaced reprecated switch #8

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

TheRojam
Copy link

@TheRojam TheRojam commented May 1, 2021

done two things - first one is ansible and the second yunohost related
I upgraded this playbook to version min. 2.10, which introduced collection naming.
I also removed the deprecated switch for mail (--mail/-m) and replaced it w/ one for domain (--domain/-d).

@sylvainar
Copy link
Owner

Thanks for your PR. I'd be happy to merge, however I'm not confortable with the fact that we disable password connection, it'll break existing setups. You should either remove it or add a parameter to the role so it's disabled by default.

Is the role still working if you're not providing any ssh key for admins? I haven't use yunohost in a while and I don't know if it's mandatory.

@TheRojam
Copy link
Author

TheRojam commented May 1, 2021

there are some difficulties :D but its not about the admin users. the sshkeys are not mandatory, buts for vps or cloud servers this is best practice or big suggestion from the view of security. 👍🏿

TheRojam and others added 20 commits May 1, 2021 21:58
This feature is system-related, not yunohost-related
✅Resolve "remove admin users feature"

Closes #1

See merge request lydra/yunohost/ansible-yunohost!2
Resolve "ci: add ansible lint and checks"

Closes #4

See merge request lydra/yunohost/ansible-yunohost!1
refactor: changed variables pattern to be more consistent with ansible good practises and more flexible to use.
refactor: remove useless comment
doc: Readme in English and French
✅Resolve "refactor vars"

Closes #2 and sylvainar#9

See merge request lydra/yunohost/ansible-yunohost!3
Shell module is not needed here.

According to various sources (https://www.youtube.com/watch?v=57gAqKvAKck or https://stackoverflow.com/questions/56663332/difference-between-shell-and-command-in-ansible) it is not useful to use shell ansible module when not working with operands. Therefore I have decided to switch every actions to command module, more secure. Ansible-lint says "Shell should only be used when piping, redirecting or chaining commands"
✅Resolve "Use command module"

Closes #10

See merge request lydra/yunohost/ansible-yunohost!6
…pport latest ansible versions

Ansible-lint:
```
Include has some unintuitive behaviours depending on if it is running in a static or dynamic in play or in playbook context, in an effort to clarify behaviours we are moving to a new set modules (ansible.builtin.include_tasks, ansible.builtin.include_role, ansible.builtin.import_playbook, ansible.builtin.import_tasks) that have well established and clear behaviours.
This module will still be supported for some time but we are looking at deprecating it in the near future.
```

Fix: I have decided to go for ansible include_tasks module because it is more versatile and on a par with this module (for more info about differences between new modules, see [here](https://docs.ansible.com/ansible/latest/collections/ansible/builtin/include_module.html)
…ster'

✅Resolve "ansible include module is to be deprecated"

Closes #14

See merge request lydra/yunohost/ansible-yunohost!7
- fix: [201] Trailing whitespace REMOVED
- fix: meta-no-tags: Use 'galaxy_tags' rather than 'categories' REPLACED + role in Debian 10 only
- fix: [601] Don't compare to literal True/False FIXED
…ster'

✅Resolve "fix: ci lint"

Closes #12

See merge request lydra/yunohost/ansible-yunohost!5
✅Resolve "GitHub default branch"

Closes #23

See merge request lydra/yunohost/ansible-yunohost!11
Resolve "Add badges on readme for github"

Closes #18

See merge request lydra/yunohost/ansible-yunohost!10
cchaudier and others added 13 commits October 15, 2021 12:55
Resolve "doc: change ansible id"

Closes #24

See merge request lydra/yunohost/ansible-yunohost!12
Resolve "doc: review"

Closes sylvainar#8

See merge request lydra/yunohost/ansible-yunohost!8
✅Resolve "doc: licence information"

Closes #15

See merge request lydra/yunohost/ansible-yunohost!9
✅Resolve "default folder instead of defaultS"

Closes #30

See merge request lydra/yunohost/ansible-yunohost!13
✅Resolve "add smtp relay"

Closes #31

See merge request lydra/yunohost/ansible-yunohost!14
Resolve "feat: add app post_install"

Closes #32

See merge request lydra/yunohost/ansible-yunohost!16
merge improvements from fork
@TheRojam
Copy link
Author

TheRojam commented Jan 2, 2022

i already merge some improvements by @cchaudier

@cchaudier
Copy link

Thanks @TheRojam for merged our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants