Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Fixed Zoom Levels #165

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added Fixed Zoom Levels #165

wants to merge 5 commits into from

Conversation

cs-mt
Copy link

@cs-mt cs-mt commented Mar 5, 2023

Hi. I made changes so that the zoom-ins and zoom-outs made using the mouse scroll would have fixed percentages between 3% and 500%. It defaults to the previous exponent calculation outside of these levels. These levels are fixed in the code, but this can be made into a setting so that users can have their own fixed sizes.

@sylikc sylikc added enhancement New feature or request config opts Related to configuration options, config files, or keymap files labels Mar 5, 2023
@sylikc
Copy link
Owner

sylikc commented Mar 5, 2023

Interesting... looks even better now that it's configurable. Give me a few days to run it through the debugger and get this tested. After having messed with zoom so much for the last release I want to see if there's any bugs in the actual zoom portion of the code.

How does it handle it now when the zoom step exceeds the maximum allowed for that image, and it "snaps back" to the % that's currently allowed? Does it try again to zoom to that at the next try?

@cs-mt
Copy link
Author

cs-mt commented Mar 5, 2023

Interesting... looks even better now that it's configurable. Give me a few days to run it through the debugger and get this tested. After having messed with zoom so much for the last release I want to see if there's any bugs in the actual zoom portion of the code.

How does it handle it now when the zoom step exceeds the maximum allowed for that image, and it "snaps back" to the % that's currently allowed? Does it try again to zoom to that at the next try?

If the zoom step is outside of the defined range, it defaults to the exponent calculation.

@cs-mt cs-mt mentioned this pull request Mar 5, 2023
Open
@sylikc sylikc added this to the Pending Features milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylikc sylikc sylikc left review comments

Assignees
No one assigned
Labels
config opts Related to configuration options, config files, or keymap files enhancement New feature or request
Projects
None yet
Milestone
Pending Features
Development

Successfully merging this pull request may close these issues.
2 participants
@cs-mt @sylikc