Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

broken table formatting #289

Closed
dmig opened this issue Aug 15, 2024 · 5 comments
Closed

broken table formatting #289

dmig opened this issue Aug 15, 2024 · 5 comments

Comments

@dmig
Copy link

dmig commented Aug 15, 2024

  • mdcat version 2.3.1
  • gnome console 46.0-2.1

steps to reproduce:

wget -O - https://raw.githubusercontent.com/swsnr/mdcat/main/README.md | mdcat

expected output - something like:

| Terminal                   |  Basic syntax | Syntax highlighting | Images | Jump marks |
| :------------------------- | :-----------: | :-----------------: | :----: | :--------: |
| Basic ANSI¹                | ✓             | ✓                   |        |            |
| Windows 10 console         | ✓             | ✓                   |        |            |
| [Terminology]              | ✓             | ✓                   | ✓      |            |
| [iTerm2]                   | ✓             | ✓                   | ✓³     | ✓          |
| [kitty]                    | ✓             | ✓                   | ✓³     |            |
| [WezTerm]                  | ✓             | ✓                   | ✓³     |            |

actual output:

| Terminal                   |  Basic syntax | Syntax highlighting | Images | Jump marks | | :------------------------- | :-----------: | :-----------------:
| :----: | :--------: | | Basic ANSI¹                | ✓             | ✓                   |        |            | | Windows 10 console         | ✓
| ✓                   |        |            | | Terminology              | ✓             | ✓                   | ✓      |            | | iTerm2
| ✓             | ✓                   | ✓³     | ✓          | | kitty                    | ✓             | ✓                   | ✓³     |            | | 
WezTerm                  | ✓             | ✓                   | ✓³     |            | | VSCode                   | ✓             | ✓                   | ✓³
|            |
@dmig
Copy link
Author

dmig commented Aug 15, 2024

mdcat 2.1.1
kitty 0.35.2

same issue

@pengjiz
Copy link
Contributor

pengjiz commented Aug 15, 2024

Per README, tables are not supported yet:

Not supported:

  • CommonMark extensions for footnotes and tables.

See also #2.

@dmig
Copy link
Author

dmig commented Aug 15, 2024

Ok, then it makes sense to pass-thru tables without reformatting them.

@pengjiz
Copy link
Contributor

pengjiz commented Aug 15, 2024 via email

@swsnr
Copy link
Owner

swsnr commented Aug 16, 2024

To be honest I do not particularly care either way. Tables were never supported; it's been like this ever since this tool exists, and so far no one bothered enough to make a pull request 🤷

I guess any change is an improvement, but someone needs to step up and do it, and it won't be me.

So do feel welcome to make a pull request to improve table support in any way. Meanwhile, though, I'll close this as not planned as I myself do not intend to work on it.

@swsnr swsnr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2024
@pengjiz pengjiz mentioned this issue Sep 1, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swsnr @dmig @pengjiz