Add MIXInvite, MIXInvitation and MIXInvitationAck Element #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UpdateSubscription feature for subscribing to additional MIX nodes Add Joining a channel with a preference form Add requesting user preference form and updating the preferences License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details. Test-Information: Tests added for joining and leaving a channel as in XEP-0369, which passes. Tests also added for updating subscription, joining channel with preference form and requesting user preference form as in XEP-0369, which passes. Tested on Ubuntu 16.04 LTS. Change-Id: Ibc2737f6154eeee1a85e98cb5f80c8bdbad35dcd
Add elements with their parser and serializers. License: This patch is BSD-licensed, see Documentation/Licenses/BSD-simplified.txt for details. Test-Information: Added tests for elements parsers and Serializers based on examples in XEP 0369, which passes. Tested on Ubuntu 16.04 LTS. Change-Id: Ib5bcdee5f02681cecc0c3fd30d19627be483a7c1
tarun018
commented
Jul 22, 2017
|
|
||
| std::string expectedResult = "<invitation-ack xmlns=\"urn:xmpp:mix:0\">" | ||
| "<value>Joined</value>" | ||
| "<invitation xmlns=\"urn:xmpp:mix:0\">" |
There was a problem hiding this comment.
Since MIXInvitation is required as a payload element (Example 57, 58), I couldn't find a way around this. The namespace with element is required as per example 57.
tarun018
commented
Jul 22, 2017
| invite->setInvitation(invitation); | ||
|
|
||
| std::string expectedResult = "<invite xmlns=\"urn:xmpp:mix:0\">" | ||
| "<invitation xmlns=\"urn:xmpp:mix:0\">" |
There was a problem hiding this comment.
Since MIXInvitation is required as a payload element (Example 57, 58), I couldn't find a way around this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.