-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix This Query challenge repair #294
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are in svg format
wtgee
reviewed
Sep 19, 2019
_episodes/03-filter.md
Outdated
> Suppose we want to select all sites that lie more than 48 degrees from the poles. | ||
> Suppose we want to select all sites that lie more than 42 degrees from the poles. | ||
> | ||
> Remember that 0 latitude is at the equator, not the pole, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
> Remember that 0 latitude is at the equator, not the pole, | |
> Remember that 0° latitude is at the equator, not the pole, |
wtgee
reviewed
Sep 19, 2019
_episodes/03-filter.md
Outdated
> Suppose we want to select all sites that lie more than 42 degrees from the poles. | ||
> | ||
> Remember that 0 latitude is at the equator, not the pole, | ||
> Hence 42 degrees from the pole is latitude 48°. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
> Hence 42 degrees from the pole is latitude 48°. | |
> Hence 42° from the pole is latitude 48°. |
Just cleaning up a few inconsistencies in how we refer to 'degrees'
- Add pictures to explain - use 42° instead of 48° From the contributions and discussions of: @Denubis Brian Ballsun-Stanton <Denubis@users.noreply.github.com> @wtgee Wilfred Tyler Gee <wtylergee@gmail.com> @remram44 closes swcarpentry#292, swcarpentry#291 ref: swcarpentry#273 swcarpentry#214 and swcarpentry#278.
22c0bd2
to
8e823f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pictures to explain
Use 42° instead of 48°
From the contributions and discussions of:
@Denubis, @wtgee, @remram44
closes #292, #291
ref: #273 #214 and #278.